Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter handling is inconsistent #114

Open
Tillaert opened this issue Jul 8, 2023 · 2 comments
Open

Parameter handling is inconsistent #114

Tillaert opened this issue Jul 8, 2023 · 2 comments

Comments

@Tillaert
Copy link

Tillaert commented Jul 8, 2023

Currently, parameters that are objects are not encoded as strings, however, arrays are.

Object parameter: https://github.com/hyperledger/firefly-fabconnect/blob/main/internal/rest/utils/params_test.go#L91
Array parameter: https://github.com/hyperledger/firefly-fabconnect/blob/main/internal/rest/utils/params_test.go#L306

This is not consistent, and begs the question how to pass objects with nested arrays and arrays of objects.

Tests are missing for objectArray.

Firefly is sending objects encoded as strings, and this results in errors, see:

hyperledger/firefly#1307

@Tillaert
Copy link
Author

Tillaert commented Jul 8, 2023

@DerekJarvis You have more insight into this?

@DerekJarvis
Copy link
Contributor

@DerekJarvis You have more insight into this?

Sorry - haven't worked with Firefly for some time. I did a PR that tried to improve some type handling, but overall it doesn't seem like a current focus of Firefly to handle the complex data types that Hyperledger Fabric supports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants