Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #446, #447 issues. 1) Only refresh the events bound by echart when the event changes. 2) If the style or classname changes, it's more reasonable to refresh the data after performing charts.resize first. #444

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix #446, #447 issues. 1) Only refresh the events bound by echart when the event changes. 2) If the style or classname changes, it's more reasonable to refresh the data after performing charts.resize first. #444

wants to merge 4 commits into from

Conversation

iitodo
Copy link

@iitodo iitodo commented Aug 4, 2021

  1. 仅事件变化时只刷新echart绑定的事件；
  2. 如果style或者className变化，先进行echarts.resize再刷新数据更合理

@iitodo iitodo changed the title Code logic optimization Optimize handling onEvents, style, and className changes Aug 4, 2021
@iitodo iitodo changed the title Optimize handling onEvents, style, and className changes Fix #446, #447 issues. 1) Only refresh the events bound by echart when the event changes. 2) If the style or classname changes, it's more reasonable to refresh the data after performing charts.resize first. Aug 8, 2021
hustcc
hustcc reviewed Oct 27, 2021
View reviewed changes
src/core.tsx Outdated Show resolved Hide resolved
hustcc
hustcc reviewed Oct 27, 2021
View reviewed changes
src/core.tsx Outdated Show resolved Hide resolved
@hustcc
Copy link
Owner

hustcc commented Oct 27, 2021

另外，求帮忙加一个单侧，针对这个修改。

@Clebal
Copy link

Clebal commented Oct 29, 2021

Pretty useful @iitodo 🚀. I've linked your repo in my project, and it works like charm when managing events.

@VictorVelarde
Copy link

Hi @hustcc. We're pretty interested in this PR to move on, how can we help?

@VictorVelarde VictorVelarde mentioned this pull request Feb 17, 2022
Merged
@cd-a
Copy link

cd-a commented Apr 16, 2022

Any chance this can be merged @hustcc?

@hustcc
Copy link
Owner

hustcc commented Sep 28, 2022

image

run test case error in locale. @iitodo

@aaranadev aaranadev mentioned this pull request Jan 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iitodo @hustcc @Clebal @VictorVelarde @cd-a