fix(next): parse <script module>
tags for imports
#1551
Merged
+35
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1534
The root of #1534 was actually that the
index.json
andbutton.json
files did not includebits-ui
as a dependency. With a little (a lot more than I am proud of) digging I figured out that we aren't parsing the<script module>
tags in.svelte
files. (I did this same thing in my own project need to go fix that now).This PR adds second walk of the
<script module>
tag if it exists so that we catch all the imports.