Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next): parse <script module> tags for imports #1551

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ieedan
Copy link
Contributor

@ieedan ieedan commented Dec 12, 2024

Fixes #1534

The root of #1534 was actually that the index.json and button.json files did not include bits-ui as a dependency. With a little (a lot more than I am proud of) digging I figured out that we aren't parsing the <script module> tags in .svelte files. (I did this same thing in my own project need to go fix that now).

This PR adds second walk of the <script module> tag if it exists so that we catch all the imports.

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 82f2c01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 12, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 82f2c01

@ieedan
Copy link
Contributor Author

ieedan commented Dec 12, 2024

You can prove this works by looking at the preview:
https://85a03792.shadcn-svelte.pages.dev/registry/index.json
versus the current:
https://next.shadcn-svelte.com/registry/index.json

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man!

@huntabyte huntabyte changed the title fix(next): ensure build parses <script module> tags for imports fix(next): parse <script module> tags for imports Dec 13, 2024
@huntabyte huntabyte merged commit e769f9b into huntabyte:next Dec 13, 2024
6 checks passed
@ieedan ieedan deleted the build-fixes-branch branch December 13, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants