-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(next): Update command doesn't update component code #1421
Conversation
🦋 Changeset detectedLatest commit: 23b5236 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
I am going to try and add a few tests before it merges working on that now |
Tests are done so should be all good now! |
@huntabyte Let me know if I should take a look at #1368. Is the expected behavior to just remove |
For now I just made it so that if the user selected utils we just remove utils from the end of the selectedComponents array so that we don't try and later fetch it from the registry. |
fixes #1368 |
Thanks @ieedan! We've discussed removing the |
I think it is still useful especially when I have a big project and I don't want to type out every component it's a bit more ergonomic to choose each component to update. |
Thanks for the PR! I'll be sure to give this a review over the weekend |
this is excellent. thank you!! |
If you ran
npx shadcn-svelte@next update
before you would notice that even though it completes successfully it doesn't actually update the code for any components.PS: This sounds super rude reading it back but I can't think of a better way to word it so it's really not intentional