Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE-HEADER confused license scanning #247

Open
jerbob92 opened this issue Dec 2, 2024 · 2 comments
Open

LICENSE-HEADER confused license scanning #247

jerbob92 opened this issue Dec 2, 2024 · 2 comments

Comments

@jerbob92
Copy link

jerbob92 commented Dec 2, 2024

Hi!

I'm trying to find out why this projects appears with the license Other on https://libraries.io/pypi/tomli and unknown on https://deps.dev/pypi/tomli.

It appears that the file [LICENSE-HEADER](https://github.com/hukkin/tomli/blob/master/LICENSE-HEADER) is the culprit, and that that confuses GitHub as well:

image

Any chance this file can be renamed?

@hukkin
Copy link
Owner

hukkin commented Dec 2, 2024

Hey there!

I'm not a lawyer.

This repository was originally MIT licensed. Moving to Python standard library required it to be relicensed to PSF under a Contributor Agreement. My understanding is in my case it meant Apache v2.0, and that the licenses co-exist. I believe I'm not required to mention the relicensing in this repository, but I don't know. I think it's only CPython that needs it to be able to redistribute. Keeping it here does, however, make maintaining the backport a bit easier.

To answer your question

Any chance this file can be renamed?

Probably yes, but why should we? Why is it a problem that the license shows as e.g. "MIT, Unknown licenses found"? Seems to me like that might be closer to truth than only "MIT".

@jerbob92
Copy link
Author

jerbob92 commented Dec 2, 2024

Hey! It's fine to have multiple licenses, that's not the issue here. The main issue is that the filename LICENSE-HEADER is used, all files starting with LICENSE are considered a license file afaik, multiple tools can't automatically detect which license the project has since LICENSE-HEADER doesn't contain an actual license, and thus requires people to manually check the license of the project.

Since the file LICENSE-HEADER is only used to inject into the source code:

args: ['--license-filepath', 'LICENSE-HEADER']

I think the easiest fix is to rename LICENSE-HEADER to something else to stop confusing the license detection tools (for example .license-header).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants