Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Gemini API Support #1330

Merged
merged 8 commits into from
Jul 18, 2024

Conversation

toandev95
Copy link
Contributor

Contribute code that supports the Google Gemini API.
https://github.com/google-gemini/generative-ai-js#readme

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool contribution, @toandev95!

@mishig25 mishig25 mentioned this pull request Jul 10, 2024
2 tasks
@nsarrazin nsarrazin added enhancement New feature or request back This issue is related to the Svelte backend or the DB models This issue is related to model performance/reliability labels Jul 12, 2024
@nsarrazin nsarrazin self-assigned this Jul 16, 2024
Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contrib, would be very happy to merge it! Couple things that I think need updating:

  • Could we expand the doc in google.md a bit to explain the difference with the vertex endpoints, and explain how to use it a bit more ?
  • Could we make @google/generative-ai an optional dependency like the other providers ?

Other than that lgtm!

@nsarrazin nsarrazin removed their assignment Jul 16, 2024
@toandev95
Copy link
Contributor Author

Hi, thanks for the contrib, would be very happy to merge it! Couple things that I think need updating:

  • Could we expand the doc in google.md a bit to explain the difference with the vertex endpoints, and explain how to use it a bit more ?
  • Could we make @google/generative-ai an optional dependency like the other providers ?

Other than that lgtm!

Thank you @nsarrazin, is there any chance you could take a look at my latest commit? Feel free to let me know if you have any additional comments

Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for contributing

@nsarrazin nsarrazin merged commit 8461fd6 into huggingface:main Jul 18, 2024
4 checks passed
@toandev95 toandev95 deleted the feat/google-genai-support branch July 30, 2024 03:23
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
* Supports Google Gemini API

* Fixed error when running svelte-check

* update: from the contribution of nsarrazin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back This issue is related to the Svelte backend or the DB enhancement New feature or request models This issue is related to model performance/reliability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants