feat: allow disabling metrics server, consolidate exit handlers #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarrazin
approved these changes
Jul 1, 2024
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
…ingface#1201) * feat: allow disabling metrics server, consolidate exit handlers * Make server off by default, enable in prods, update docs accordingly --------- Co-authored-by: Nathan Sarrazin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics server causes issues in development due to the Sveltekit not allowing us to hook into restarts (as far as I could tell). This allows disabling the metrics server with
METRICS_ENABLED=falseand a bit of documentation to recommend this setting for development (maybe it should be default?). I've also consolidated the exit handler code to make signal handling more consistent