Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cdn call to katex.min.css may unnecessarily cause slowdowns due to timeouts when behind a firewall. #1625

Open
jrokiskyjhuapl opened this issue Dec 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jrokiskyjhuapl
Copy link

Bug description

In src/routes/conversation/[id]/+page.svelte on line 275, there is an href call to load katex from an external cdn.

It looks like this may no longer be needed with the introduction of the MarkdownRenderer component (commit 69a7610). Trying to fetch this external resource when behind a firewall may cause slowdowns the first time a chat message is sent.

Steps to reproduce

  • Launch the chat-ui behind a firewall that does not have access to the external internet
  • Open your browsers inspection tool and watch the network requests
  • Send a chate message
  • Notice that the request for the katex.min.css may take a while to timeout

Screenshots

N/A

Context

Logs

N/A

Specs

  • OS: Ubuntu
  • Browser: Firefox
  • chat-ui commit: 6623d11

Config

N/A

Notes

I have removed the <link> component that is trying to load the katex stylesheet. I believe I am able to still get latex markdown generated without it, but someone more familiar with the codebase might know if this <link> component is still needed.

Thanks for releasing this!

@jrokiskyjhuapl jrokiskyjhuapl added the bug Something isn't working label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant