Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP.get not always returning response body #523

Closed
arjunrajkumar opened this issue Feb 1, 2019 · 5 comments
Closed

HTTP.get not always returning response body #523

arjunrajkumar opened this issue Feb 1, 2019 · 5 comments

Comments

@arjunrajkumar
Copy link

arjunrajkumar commented Feb 1, 2019

Saw the examples - and HTTP.get("https://github.com").to_s returns the pages HTML.

But trying with a few other websites and its only returning a string.

e.g. HTTP.get("https://www.irepair.in/").to_s or HTTP.get("https://www.wiinnova.com/").to_s returns empty string.

Just wondering if i'm missing something - or this works on some websites.

Any advice on how to fix this? Thanks.

@ixti
Copy link
Member

ixti commented Feb 1, 2019

It's known issue which is fixed in master and I will release new major version as soon as possible. It's related to improper handling of Upgrade response headers.

Related issues:

I'm gonna cut 5.0.0-alpha1 gem this weekend with changes in master.

@arjunrajkumar
Copy link
Author

Thanks 🙏

@tarcieri
Copy link
Member

tarcieri commented Feb 2, 2019

Closing as a duplicate

@tarcieri tarcieri closed this as completed Feb 2, 2019
@arjunrajkumar
Copy link
Author

I'm gonna cut 5.0.0-alpha1 gem this weekend with changes in master

Hey.. Just checking if updates on this. Whenever you get the time. Thanks!

@tarcieri
Copy link
Member

This is a dup of #485. Please see the status update there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants