Add CRC32 calc #14000
Merged
Add CRC32 calc #14000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hrydgard#13964 Thanks @unknownbrackets
|
I don't know about this for 1.11 ... If this is something we really need to have, I'd like to make it fit into the UI better. A button name "CRC CALC" is incomprehensible for most users, and changing the text of the button instead of showing the CRC to the left with all the other game data is a little odd. I'm gonna postpone to 1.12 and figure out what exactly we'll do with this. |
|
Changed this to disable the button during calculation and remove it when it is done. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13964
Thanks @unknownbrackets
Do we also add in this screen ?
