Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prevent Mipmaps from being dumped #12818

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Add option to prevent Mipmaps from being dumped #12818

merged 3 commits into from
Apr 13, 2020

Conversation

NR74W
Copy link
Contributor

@NR74W NR74W commented Apr 13, 2020

WipEout Pure and Pulse use mipmapping for just about anything;
it is a huge waste of time to sort / blacklist every mip levels to prevent the 'new' folder from being cluttered.

This small change will be very useful to texture modders for games relying massively on mipmaps.

I'm not sure about the name of the setting though, so perhaps anyone has a suggestion ?

@JuliusSenkus
Copy link
Contributor

@NR74W Suggestion ignoreMipmaps?

@JuliusSenkus
Copy link
Contributor

Also just a recommendation, you might leave short comment in front of the boolean variable, why it was added, so someone accidentally would not remove it (don't know exact this repository code recommendations, so just my opinion here).

@hrydgard hrydgard merged commit 05a5154 into hrydgard:master Apr 13, 2020
@unknownbrackets unknownbrackets added this to the v1.10.0 milestone Apr 14, 2020
@efonte
Copy link

efonte commented Apr 15, 2020

You have to add the default value of the new variable

https://github.com/hrydgard/ppsspp/blob/master/Core/TextureReplacer.cpp#L695

@hrydgard
Copy link
Owner

@efonte Done.

@NR74W NR74W deleted the texture-replacement branch May 31, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants