-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom exit command implementation #275
Conversation
Thanks for creating this PR. I'm in favour of such a change. I suggest a slightly different implementation though: make this option part of the global options passed to the |
Got it. Will implement this tomorrow.
Yes. I will add that. |
Ok, everything should be implemented now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can you address the comment and add a description to the README? Then it's good to go. (If you can, a test for this would be appreciated)
Co-authored-by: Joram van den Boezem <[email protected]>
I'm not familiar with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
# [1.7.0](v1.6.4...v1.7.0) (2021-07-29) ### Features * allow custom exit command implementation ([#275](#275)) ([9527735](9527735)) [skip ci]
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I'm creating a CLI which runs in an async context with init and dispose hooks. Just calling
process.exit()
when the user typesexit
may be fatal.This change allows for custom implementation for an
exit
command.