Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing + code coverage #98

Merged
merged 22 commits into from
Jul 3, 2019
Merged

Testing + code coverage #98

merged 22 commits into from
Jul 3, 2019

Conversation

holgerteichgraeber
Copy link
Owner

In #91, there are several TODOs concerning which functions still need test coverage. Let's implement them after this PR.

Merging this PR right away, for a reproducible version of the changes and for your comments @YoungFaithful , use #97 .

@holgerteichgraeber holgerteichgraeber self-assigned this Jul 3, 2019
@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@e13cb90). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev      #98   +/-   ##
======================================
  Coverage       ?   64.46%           
======================================
  Files          ?        9           
  Lines          ?      515           
  Branches       ?        0           
======================================
  Hits           ?      332           
  Misses         ?      183           
  Partials       ?        0
Impacted Files Coverage Δ
src/clustering/run_clust.jl 88.54% <100%> (ø)
src/utils/load_data.jl 71.42% <16.66%> (ø)
src/clustering/extreme_vals.jl 84.21% <33.33%> (ø)
src/utils/utils.jl 83.15% <50%> (ø)
src/utils/datastructs.jl 97.36% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13cb90...c53c37c. Read the comment docs.

@holgerteichgraeber
Copy link
Owner Author

Tests sometimes fail due to memory on travis ( #99 ) , reloading the build seems to be a doable workaround for now,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant