Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regarding add and norm block #29

Open
DevasishY opened this issue Jul 26, 2024 · 1 comment
Open

Regarding add and norm block #29

DevasishY opened this issue Jul 26, 2024 · 1 comment

Comments

@DevasishY
Copy link

DevasishY commented Jul 26, 2024 •
edited
Loading

The provided code is x+sublayer(self.norm(x)) in model.py residual connection function
but in paper it mentioned add and norm, that does mean self.norm(x+sublayer(x)).
please clarify the same.
@SeekPoint
Copy link

Yes，The Paper is differ from Umar's code
Umar comfirmed that in his video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SeekPoint @DevasishY