Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: make subscribeConfirmLink a config rather than a form data #13

Open
cyChop opened this issue Aug 17, 2021 · 1 comment
Open

Comments

@cyChop
Copy link

cyChop commented Aug 17, 2021

For the case of double opt-in for notifications, the subscribeConfirmUrl must be provided as a field of options in the form. However, I think this link is not related to a specific comment. As such, I'm not sure it belongs in the form.

It would appear more logical to me to make it part of the site config (I know where my server is) or the server config (I know where I, the server, am).

Or is it for GDPR purpose, in order to save this information along with the rest?

@hispanic
Copy link
Owner

hispanic commented Sep 5, 2021

Good point. After revisiting the code, I imagine it could be incorporated into the JSON config schema and sourced from the server config. It was first added as part of the GDPR-compliance pull request, but it isn't one of the data points saved for that purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants