-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added list of false positiitives #3999
base: main
Are you sure you want to change the base?
Conversation
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +551 B View Changes
|
src/languages/cpp.js
Outdated
/(?!char)/, | ||
/(?!double)/, | ||
/(?!float)/, | ||
/(?!bool)/, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I've mentioned above only happens without ;
Just forget it.
Could we build the exclude list dynamically from our keywords list then instead of repeating ourselves? |
Sure |
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +136 B View Changes
|
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +133 B View Changes
|
…light.js into fix/issue-3980
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +135 B View Changes
|
hi @joshgoebel, can you please tell me if our engine has a priority based highlighting or it is just limited to regex. if no such feature exists, should we add this feature to our engine for better control over it? |
@@ -61,6 +61,7 @@ CAVEATS / POTENTIALLY BREAKING CHANGES | |||
|
|||
Core Grammars: | |||
|
|||
- fix(cpp) Keywords followed by parens are treated as built_in [Md Saad Akhtar][] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add your author link below as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping.
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +130 B View Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All we need is that link then we can get this merged! Thanks for your patience.
/(?!switch)/, | ||
/(?!while)/, | ||
// adds all keywords dynamically | ||
...allKeywords.map(keyword => new RegExp(`(?!${keyword})`)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually don't we only care about keywords here that can potentially have a (
following them? That's not ALL keywords, is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can ignore this for now since I already said this was ready but need your author link...
Issue: (cpp) Keywords followed by parens are treated as built_in
Resolves #3980
Changes
Added list of false positives to
FUNCTION_DISPATCH
The List:
Before:
After:
Checklist
CHANGES.md