Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(nsis) Incorrect highlighting of keywords #3821

Open
idleberg opened this issue Jul 16, 2023 · 2 comments
Open

(nsis) Incorrect highlighting of keywords #3821

idleberg opened this issue Jul 16, 2023 · 2 comments
Labels
autoclose Flag things to future autoclose. bug help welcome Could use help from community language

Comments

@idleberg
Copy link
Contributor

idleberg commented Jul 16, 2023

Describe the issue

I have identified several cases where the highlighting for NSIS keywords is incorrect:

  • keywords should only highlight when at the beginning of the line (with or without leading whitespace)
  • keyword blocks should highlight both, the opening and closing keywords

See failing tests for specifics.

Which language seems to have the issue?

NSIS

Are you using highlight or highlightAuto?

Neither. I'm using the Mocha tests.

Expected behavior

Keywords should be highlighted correctly.

@joshgoebel
Copy link
Member

@idleberg Any interest in coming back and finishing this one? Otherwise may close this issue for age. This seems to be an obscure language (at least based the activity level around it) and I try and limit our open issues to something reasonable, those we might expect someone to show up and be able to jump into.

If you'd like to flesh out your two items a bit further in the issue (so that someone not familiar with NSIS could maybe pick this up) with actual examples, failing cases, etc... we might be able to leave this around a while longer.

Thoughts?

@joshgoebel joshgoebel added the autoclose Flag things to future autoclose. label Oct 31, 2024
@idleberg
Copy link
Contributor Author

idleberg commented Nov 3, 2024

@joshgoebel Thanks for the reminder, I will give this another go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoclose Flag things to future autoclose. bug help welcome Could use help from community language
Projects
None yet
Development

No branches or pull requests

2 participants