-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include action ID in action error string #539
Conversation
This allows us to easily debug the failed action from user provided logs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
- Coverage 71.44% 67.50% -3.95%
==========================================
Files 46 46
Lines 3933 4871 +938
==========================================
+ Hits 2810 3288 +478
- Misses 711 1171 +460
Partials 412 412 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a unit test for this?
b9e81d8
to
21e5be5
Compare
🤖 I have created a release *beep* *boop* --- ## [2.14.0](v2.13.1...v2.14.0) (2024-10-21) ### Features * add support for Go 1.23 ([#532](#532)) ([838f878](838f878)) * allow retrieving the action from an action error ([#538](#538)) ([07727d3](07727d3)) * include action ID in action error string ([#539](#539)) ([ad5417f](ad5417f)) ### Bug Fixes * deprecate pricing floating ip field ([#523](#523)) ([1089d40](1089d40)) * deprecate unused window parameter in the `EnableBackup` call ([#531](#531)) ([584f6c2](584f6c2)), closes [#525](#525) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…4.0 (hetznercloud/fleeting-plugin-hetzner!141) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.13.1` -> `v2.14.0` | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.14.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.14.0) [Compare Source](hetznercloud/hcloud-go@v2.13.1...v2.14.0) ##### Features - add support for Go 1.23 ([#​532](hetznercloud/hcloud-go#532)) ([838f878](hetznercloud/hcloud-go@838f878)) - allow retrieving the action from an action error ([#​538](hetznercloud/hcloud-go#538)) ([07727d3](hetznercloud/hcloud-go@07727d3)) - include action ID in action error string ([#​539](hetznercloud/hcloud-go#539)) ([ad5417f](hetznercloud/hcloud-go@ad5417f)) ##### Bug Fixes - deprecate pricing floating ip field ([#​523](hetznercloud/hcloud-go#523)) ([1089d40](hetznercloud/hcloud-go@1089d40)) - deprecate unused window parameter in the `EnableBackup` call ([#​531](hetznercloud/hcloud-go#531)) ([584f6c2](hetznercloud/hcloud-go@584f6c2)), closes [#​525](hetznercloud/hcloud-go#525) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjguNiIsInVwZGF0ZWRJblZlciI6IjM4LjEyOC42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
This allows us to easily debug the failed action from user provided logs.