Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to Node.js binary download #868

Open
edmorley opened this issue Jun 27, 2024 · 1 comment
Open

Add retries to Node.js binary download #868

edmorley opened this issue Jun 27, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@edmorley
Copy link
Member

To reduce the chance of intermittent failures like:

[Heroku Node.js Engine Buildpack]

[Checking Node.js version]
Detected Node.js version range: >=20.0.0 <21.0.0-0
Resolved Node.js version: 20.15.0

[Installing Node.js distribution]
Downloading Node.js 20.15.0 (linux-amd64) from https://nodejs.org/download/release/v20.15.0/node-v20.15.0-linux-x64.tar.gz

[Error: Node.js engine distribution error]
Couldn't download Node.js distribution: I/O error while downloading file: response body closed before all bytes were read

As seen in:
https://github.com/heroku/cnb-builder-images/actions/runs/9699157499/job/26767524369?pr=541#step:6:27
https://github.com/heroku/cnb-builder-images/actions/runs/9699157499/job/26767523738?pr=541#step:6:28

@colincasey colincasey added the enhancement New feature or request label Jun 28, 2024
@colincasey colincasey self-assigned this Jun 28, 2024
@usiegj00
Copy link

Seeing this too in a build that worked fine with the Heroku-themed buildpack. Can you articulate the difference in operation between the two buildpacks? This would help point to a potential fix here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants