From b8a4310c314269512abdc46253d77ce2e7743d8d Mon Sep 17 00:00:00 2001 From: Simon Gabriel Date: Wed, 19 Sep 2018 16:34:57 +0200 Subject: [PATCH 1/3] [bugfix] (MAGE2-92) Replace company not set check due to incompatibility with new security patch. --- PaymentMethods/HeidelpayDirectDebitSecuredPaymentMethod.php | 2 +- PaymentMethods/HeidelpayInvoiceSecuredPaymentMethod.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PaymentMethods/HeidelpayDirectDebitSecuredPaymentMethod.php b/PaymentMethods/HeidelpayDirectDebitSecuredPaymentMethod.php index 24e445ce97e..331f5181663 100755 --- a/PaymentMethods/HeidelpayDirectDebitSecuredPaymentMethod.php +++ b/PaymentMethods/HeidelpayDirectDebitSecuredPaymentMethod.php @@ -211,7 +211,7 @@ public function isAvailable(\Magento\Quote\Api\Data\CartInterface $quote = null) { // in B2C payment methods, we don't want companies to be involved. // so, if the address contains a company, return false. - if ($quote !== null && $quote->getBillingAddress()->getCompany() !== null) { + if ($quote !== null && !empty($quote->getBillingAddress()->getCompany())) { return false; } diff --git a/PaymentMethods/HeidelpayInvoiceSecuredPaymentMethod.php b/PaymentMethods/HeidelpayInvoiceSecuredPaymentMethod.php index 939e6d5d598..0e3033d5edd 100755 --- a/PaymentMethods/HeidelpayInvoiceSecuredPaymentMethod.php +++ b/PaymentMethods/HeidelpayInvoiceSecuredPaymentMethod.php @@ -216,7 +216,7 @@ public function isAvailable(\Magento\Quote\Api\Data\CartInterface $quote = null) { // in B2C payment methods, we don't want companies to be involved. // so, if the address contains a company, return false. - if ($quote !== null && $quote->getBillingAddress()->getCompany() !== null) { + if ($quote !== null && !empty($quote->getBillingAddress()->getCompany())) { return false; } From 02cc71581a5d901b651b58a249da7db1cadb6dec Mon Sep 17 00:00:00 2001 From: Simon Gabriel Date: Wed, 19 Sep 2018 16:43:01 +0200 Subject: [PATCH 2/3] [bugfix] (MAGE2-91) Fix version constraints in composer.json. --- etc/module.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/module.xml b/etc/module.xml index e257f6392e6..74a43f66307 100755 --- a/etc/module.xml +++ b/etc/module.xml @@ -1,5 +1,5 @@ - + From ec04c6089263bfc19b82ce5db6f5a0cb8e1d53e3 Mon Sep 17 00:00:00 2001 From: Simon Gabriel Date: Wed, 19 Sep 2018 16:43:01 +0200 Subject: [PATCH 3/3] [bugfix] (MAGE2-91) Fix version constraints in composer.json. --- CHANGELOG.md | 6 ++++++ composer.json | 6 +++--- etc/module.xml | 2 +- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 591badd6fde..3086fe7989a 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,12 @@ This project does not follow a versioning standard. Versions are crafted after the dates; for example, the version 17.7.25 was released on July, 25th in 2017 +## 18.9.20 + +### Fixed +- An issue which resulted in an error on checkout with secured payment methods with magento security patch SUPEE-10888 (Magento Version 2.2.6). +- An issue concerning the versions of the dependencies. + ## 18.8.9 ### Fixed diff --git a/composer.json b/composer.json index 5371cad0a4a..1cece134239 100755 --- a/composer.json +++ b/composer.json @@ -12,9 +12,9 @@ "magento/module-payment": "^100.0.0 | ^101.0.0", "magento/module-backend": "^100.0.0 | ^101.0.0", "magento/framework": "^100.0.0 | ^101.0.0", - "heidelpay/php-message-code-mapper": "~1.0.0", - "heidelpay/php-basket-api": "~1.0.1", - "heidelpay/php-payment-api": "~1.4.0" + "heidelpay/php-message-code-mapper": "~1.0", + "heidelpay/php-basket-api": "~1.0", + "heidelpay/php-payment-api": "~1.4" }, "require-dev": { "magento/marketplace-eqp": "~1.0.5", diff --git a/etc/module.xml b/etc/module.xml index e257f6392e6..74a43f66307 100755 --- a/etc/module.xml +++ b/etc/module.xml @@ -1,5 +1,5 @@ - +