From 349439aca33acd76e92d32bf9c82b9accc271615 Mon Sep 17 00:00:00 2001
From: Maksym Kryvchun <hedhyw@yahoo.com>
Date: Wed, 8 Jun 2022 19:18:19 +0300
Subject: [PATCH] Version flag (#28)

* cli version

* Fix linter
---
 Makefile                          | 15 +++++++--
 cmd/gherkingen/main.go            |  5 ++-
 cmd/gherkingen/main_test.go       | 11 +++++++
 internal/app/app.feature          | 16 ++++++++++
 internal/app/app.go               | 17 +++++++---
 internal/app/app_test.go          | 53 ++++++++++++++++++++++++++++++-
 internal/app/version.go           | 12 +++++++
 internal/generator/golang_test.go | 14 ++++++++
 internal/generator/raw_test.go    | 14 ++++++++
 pkg/v1/bdd/bdd_test.go            | 10 +++---
 10 files changed, 152 insertions(+), 15 deletions(-)
 create mode 100644 cmd/gherkingen/main_test.go
 create mode 100644 internal/app/version.go

diff --git a/Makefile b/Makefile
index 5490055..ac2875f 100644
--- a/Makefile
+++ b/Makefile
@@ -1,9 +1,14 @@
 GOLANG_CI_LINT_VER:=v1.45.0
 OUT_BIN?=${PWD}/bin/gherkingen
-COVER_PACKAGES=${go list ./... | grep -Ev 'examples' | tr '\n' ','}
+COVER_PACKAGES=${shell go list ./... | grep -Ev 'examples|model' | tr '\n' ','}
+VERSION=${shell git describe --tags}
 
 build:
-	go build -o ${OUT_BIN} cmd/gherkingen/main.go
+	@echo "building ${VERSION}"
+	go build \
+		-o ${OUT_BIN} \
+		--ldflags "-s -w -X main.version=${VERSION}" \
+		cmd/gherkingen/main.go
 .PHONY: build
 
 lint: bin/golangci-lint
@@ -11,7 +16,11 @@ lint: bin/golangci-lint
 .PHONY: lint
 
 test:
-	go test -coverpkg=github.com/hedhyw/gherkingen/internal/app -covermode=count -coverprofile=coverage.out ./...
+	go test \
+		-coverpkg=${COVER_PACKAGES} \
+		-covermode=count \
+		-coverprofile=coverage.out \
+		./...
 	go tool cover -func=coverage.out
 .PHONY: test
 
diff --git a/cmd/gherkingen/main.go b/cmd/gherkingen/main.go
index 6c49793..f0ecc98 100644
--- a/cmd/gherkingen/main.go
+++ b/cmd/gherkingen/main.go
@@ -6,8 +6,11 @@ import (
 	"github.com/hedhyw/gherkingen/internal/app"
 )
 
+// Version will be set on build.
+var version = "unknown"
+
 func main() {
-	if err := app.Run(os.Args[1:], os.Stdout); err != nil {
+	if err := app.Run(os.Args[1:], os.Stdout, version); err != nil {
 		// nolint: forbidigo // Command-line-tool.
 		println(err.Error())
 		os.Exit(1)
diff --git a/cmd/gherkingen/main_test.go b/cmd/gherkingen/main_test.go
new file mode 100644
index 0000000..8d36647
--- /dev/null
+++ b/cmd/gherkingen/main_test.go
@@ -0,0 +1,11 @@
+package main
+
+import (
+	"os"
+	"testing"
+)
+
+func TestMainVersion(_ *testing.T) {
+	os.Args = append(os.Args, "-version")
+	main()
+}
diff --git a/internal/app/app.feature b/internal/app/app.feature
index de3d6ce..1b42b3a 100644
--- a/internal/app/app.feature
+++ b/internal/app/app.feature
@@ -54,3 +54,19 @@ Feature: Application command line tool
   Scenario: User gives an invalid flag
     When flag -invalid is provided
     Then a generation failed
+
+  Scenario: User wants to know version
+    When <flag> is provided
+    Then version is printed
+    Examples:
+    | <flag>    |
+    | --version |
+    | -version  |
+
+  Scenario: User specifies a file, but the file is not found
+    When inexistent <template> is provided
+    And  <feature> is provided
+    Then the user receives an error
+    Examples:
+    | <feature>   | <template> |
+    | app.feature | not_found  |
diff --git a/internal/app/app.go b/internal/app/app.go
index bdfc18d..059cf40 100644
--- a/internal/app/app.go
+++ b/internal/app/app.go
@@ -18,7 +18,7 @@ const (
 )
 
 // Run the application.
-func Run(arguments []string, out io.Writer) (err error) {
+func Run(arguments []string, out io.Writer, version string) (err error) {
 	flag.CommandLine.Init(flag.CommandLine.Name(), flag.ContinueOnError)
 	flag.CommandLine.SetOutput(out)
 
@@ -37,12 +37,12 @@ func Run(arguments []string, out io.Writer) (err error) {
 		false,
 		"The same calls to the generator always produces the same output",
 	)
-	help := flag.Bool(
+	helpCmd := flag.Bool(
 		"help",
 		false,
 		"print usage",
 	)
-	list := flag.Bool(
+	listCmd := flag.Bool(
 		"list",
 		false,
 		"list internal templates",
@@ -52,6 +52,11 @@ func Run(arguments []string, out io.Writer) (err error) {
 		"generated_test",
 		"name of the generated package",
 	)
+	versionCmd := flag.Bool(
+		"version",
+		false,
+		"print version",
+	)
 	if err = flag.CommandLine.Parse(arguments); err != nil {
 		return err
 	}
@@ -70,9 +75,11 @@ func Run(arguments []string, out io.Writer) (err error) {
 	}
 
 	switch {
-	case *list:
+	case *versionCmd:
+		return runVersion(out, version)
+	case *listCmd:
 		return runListTemplates(out)
-	case *help, inputFile == "":
+	case *helpCmd, inputFile == "":
 		return runHelp()
 	default:
 		return runGenerator(
diff --git a/internal/app/app_test.go b/internal/app/app_test.go
index 001d48d..f0abdab 100644
--- a/internal/app/app_test.go
+++ b/internal/app/app_test.go
@@ -10,6 +10,8 @@ import (
 	"github.com/hedhyw/gherkingen/pkg/v1/bdd"
 )
 
+const testVersion = "0.0.1"
+
 func TestApplicationCommandLineTool(t *testing.T) {
 	f := bdd.NewFeature(t, "Application command line tool")
 
@@ -174,6 +176,55 @@ func TestApplicationCommandLineTool(t *testing.T) {
 			runApp(t, arguments, false)
 		})
 	})
+
+	f.Scenario("User wants to know version", func(_ *testing.T, f *bdd.Feature) {
+		type testCase struct {
+			Flag string `field:"<flag>"`
+		}
+
+		testCases := map[string]testCase{
+			"--version": {"--version"},
+			"-version":  {"-version"},
+		}
+
+		f.TestCases(testCases, func(t *testing.T, f *bdd.Feature, tc testCase) {
+			arguments := []string{}
+
+			f.When("<flag> is provided", func() {
+				arguments = append(arguments, tc.Flag)
+			})
+			f.Then("version is printed", func() {
+				out := runApp(t, arguments, true)
+				if !strings.Contains(out, testVersion) {
+					t.Fatalf("expected %q in %q", testVersion, out)
+				}
+			})
+		})
+	})
+
+	f.Scenario("User specifies a file, but the file is not found", func(_ *testing.T, f *bdd.Feature) {
+		type testCase struct {
+			Feature  string `field:"<feature>"`
+			Template string `field:"<template>"`
+		}
+
+		testCases := map[string]testCase{
+			"app.feature_not_found": {"app.feature", "not_found"},
+		}
+
+		f.TestCases(testCases, func(t *testing.T, f *bdd.Feature, tc testCase) {
+			arguments := []string{}
+			f.When("inexistent <template> is provided", func() {
+				arguments = append(arguments, "-template", tc.Template)
+			})
+			f.And("<feature> is provided", func() {
+				arguments = append(arguments, tc.Feature)
+			})
+			f.Then("the user receives an error", func() {
+				runApp(t, arguments, false)
+			})
+		})
+	})
 }
 
 func runApp(tb testing.TB, arguments []string, ok bool) string {
@@ -182,7 +233,7 @@ func runApp(tb testing.TB, arguments []string, ok bool) string {
 	flag.CommandLine = flag.NewFlagSet("", flag.PanicOnError)
 
 	var buf bytes.Buffer
-	err := app.Run(arguments, &buf)
+	err := app.Run(arguments, &buf, testVersion)
 
 	if ok == (err != nil) {
 		tb.Errorf("Assertion failed, ok: %t, err: %s", ok, err)
diff --git a/internal/app/version.go b/internal/app/version.go
new file mode 100644
index 0000000..283cd9f
--- /dev/null
+++ b/internal/app/version.go
@@ -0,0 +1,12 @@
+package app
+
+import (
+	"fmt"
+	"io"
+)
+
+func runVersion(w io.Writer, version string) error {
+	fmt.Fprintln(w, "github.com/hedhyw/gherkingen@"+version)
+
+	return nil
+}
diff --git a/internal/generator/golang_test.go b/internal/generator/golang_test.go
index 2da44ac..151424c 100644
--- a/internal/generator/golang_test.go
+++ b/internal/generator/golang_test.go
@@ -38,6 +38,20 @@ func TestGenerateGo(t *testing.T) {
 	}
 }
 
+func TestGenerateGoFormattingFailed(t *testing.T) {
+	t.Parallel()
+
+	_, err := generator.Generate(model.GenerateArgs{
+		Format:         model.FormatGo,
+		InputSource:    exampleFeature,
+		TemplateSource: []byte("-"),
+		PackageName:    "generated_test",
+	})
+	if err == nil {
+		t.Fatal(err)
+	}
+}
+
 func TestGenerateAssetTemplatesShouldNotFail(t *testing.T) {
 	t.Parallel()
 
diff --git a/internal/generator/raw_test.go b/internal/generator/raw_test.go
index b7734b0..b0f5817 100644
--- a/internal/generator/raw_test.go
+++ b/internal/generator/raw_test.go
@@ -52,3 +52,17 @@ func TestGenerateRaw(t *testing.T) {
 		})
 	}
 }
+
+func TestGenerateRaw_failed(t *testing.T) {
+	t.Parallel()
+
+	_, err := generator.Generate(model.GenerateArgs{
+		Format:         model.FormatRaw,
+		InputSource:    exampleFeature,
+		TemplateSource: []byte("{{"),
+		PackageName:    "generated_test.go",
+	})
+	if err == nil {
+		t.Fatal(err)
+	}
+}
diff --git a/pkg/v1/bdd/bdd_test.go b/pkg/v1/bdd/bdd_test.go
index a015b27..471e9d0 100644
--- a/pkg/v1/bdd/bdd_test.go
+++ b/pkg/v1/bdd/bdd_test.go
@@ -22,7 +22,7 @@ func TestBDDTestCases(t *testing.T) {
 
 		var gotSum int
 
-		f.TestCases(testCases, func(t *testing.T, f *bdd.Feature, tc testCase) {
+		f.TestCases(testCases, func(_ *testing.T, _ *bdd.Feature, tc testCase) {
 			gotSum += tc.Inc
 		})
 
@@ -42,19 +42,19 @@ func TestBDD(t *testing.T) {
 		called++
 	}
 
-	f.Rule("rule", func(t *testing.T, f *bdd.Feature) {
-		f.Background("background", func(t *testing.T, f *bdd.Feature) {
+	f.Rule("rule", func(_ *testing.T, f *bdd.Feature) {
+		f.Background("background", func(_ *testing.T, f *bdd.Feature) {
 			f.Then("then", inc)
 		})
 
-		f.Scenario("simple", func(t *testing.T, f *bdd.Feature) {
+		f.Scenario("simple", func(_ *testing.T, f *bdd.Feature) {
 			tc := struct {
 				Fn string `field:"<field>"`
 			}{
 				Fn: "FUNC",
 			}
 
-			f.Example("example", func(t *testing.T, f *bdd.Feature) {
+			f.Example("example", func(_ *testing.T, f *bdd.Feature) {
 				f.TestCase("testCase", tc, func(t *testing.T, f *bdd.Feature) {
 					f.Given("given <field> called", inc)
 					f.But("but <field> called", inc)