WIP: update tests #131
Closed
WIP: update tests #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunn
commented
Apr 2, 2017
| (require 'test (expand-file-name "../test.el" | ||
| twittering-test-dir)) | ||
| (setq twittering-test-dir (file-name-directory | ||
| (or load-file-name buffer-file-name))) |
There was a problem hiding this comment.
Falling back to buffer-file-name lets us run this interactively.
dunn
commented
Apr 2, 2017
| (dolist (file-name (directory-files twittering-test-dir)) | ||
| (when (string-match "^test-" file-name) | ||
| (let ((file-name (expand-file-name file-name twittering-test-dir))) | ||
| (load file-name)))) | ||
|
|
||
| (test-run-all-cases) | ||
|
|
||
| (let* ((fail-count (cdr (assoc 'fail test-last-summary))) |
There was a problem hiding this comment.
test-last-summary was removed from test.el in 0.9.1.
dunn
commented
Apr 2, 2017
| (end-of-buffer) | ||
| (search-backward-regexp "" nil t) | ||
| (beginning-of-buffer) | ||
| (while (search-forward-regexp "\\b\\([0-9]+\\) pass\\b" nil t) |
There was a problem hiding this comment.
At some point test.el changed *test-result* to be a read-only buffer, so none of this code seems to work anymore.
dunn
commented
Apr 2, 2017
| (twittering-user-agent)) | ||
| ) | ||
| (progn | ||
| (setq twittering-user-agent-function 'twittering-user-agent-default-function) |
There was a problem hiding this comment.
From what I can tell the tests aren't always run in the exact order that the forms are given, so (setq twittering-user-agent-function (lambda () "foo user agent")) was being evaluated before the
(test-assert-string-equal (format "Emacs/%d.%d Twittering-mode/%s" [...]
test, causing it to fail.
Closed
|
Do you need anything from me before you can merge this? |
|
I don't have commit rights; I'm waiting to hear from @cvmat |
|
Ah! Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I marked this as Work In Progress since I don't know the code well enough to be sure I didn't break anything. But now I can run
make check, so this fixes #119.