-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend/azurerm: add support for generic OIDC authentication #31966
backend/azurerm: add support for generic OIDC authentication #31966
Conversation
Related to #31802 |
… documentation is more clear about it´s usage. oidc_request_url and oidc_request_token are meant to be used for Github Actions only.
0c4032f
to
bc07a54
Compare
Thanks for this submission! I'll notify the AzureRM team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution @kschu91, this mostly LGTM. I've added the additional properties to the docs along with a minor schema fix, so I will wait for a second contributor to review.
Can I please ask if this is still been worked on as we'll need to use this functionality in Azure Kubernetes Cluster and move away from pod-identity which will replaced soon with workload identity? |
@kabal2010 This is more or less ready for merging but will not be released until Terraform 1.4. |
@manicminer Thanks for a prompt response on this. Just out of curiosity, is there a timeline for this? |
@kabal2010, not at this time. "Minor" numbered releases usually happen every four months or so, but it depends on what work is slated for that release. I wish I had a clearer (or sooner!) timeline for you, but I wanted to set expectations appropriately. Hope this helps! |
@crw Thanks for that. I wish this can be made available sooner in the upcoming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks again for this PR @kschu91. We've chatted internally and we should be able to backport this to v1.3 so this will hopefully make it out in the next patch release. |
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
@manicminer |
Amazing news, thanks to all involved for the hard work!👍🏼 |
I can see this has now been released in |
Thought I'd share a blog post with example code of this working: https://adamrushuk.github.io/configure-terraform-openid-connect-oidc-authentication-from-gitlab-ci-to-azure/ |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Support for generic OIDC authentication (eg. for Gitlab or Kubernetes) has been added to azurerm provider as well as in the go-azure-helpers already:
hashicorp/terraform-provider-azurerm#16901
https://github.com/hashicorp/go-azure-helpers/blob/main/authentication/auth_method_oidc.go#L41
Currently the remote state backend only supports Github Actions. This pull requests added the support for generic OIDC as in the provider. Also, the documentation has been updated to reflect the usage.
Info: This pull request upgrades the dependency of go-azure-helpers to the latest available version.
Fixes #31802
Target Release
1.4.x
Draft CHANGELOG entry
NEW FEATURES