Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

special handling for legacy ignore_changes = all #31914

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Sep 30, 2022

Legacy providers expect Terraform to be able to clean up invalid plans and altered computed attributes. Add a special case for the LegacyTypeSystem to revert ignore_changes = all to the complete prior state, rather than the config value generated by #31747.

Fixes #31912

Legacy providers expect Terraform to be able to clean up invalid plans
and computed attributes. Add a special case for the LegacyTypeSystem to
revert `ignore_changes = all` to the complete prior state.
@jbardin jbardin added the 1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Sep 30, 2022
@jbardin jbardin requested a review from a team September 30, 2022 13:21
@jbardin jbardin self-assigned this Sep 30, 2022
@jbardin jbardin merged commit 162b727 into main Oct 4, 2022
@jbardin jbardin deleted the jbardin/ignore-all-legacy branch October 4, 2022 14:57
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore_changes=all causes replacement every time
2 participants