evaluation of missing instances during import #31878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbardin
added
the
1.3-backport
jbardin
changed the title
Because import does not yet plan new instances as part of the import process, we can end up evaluating references to resources which have no state at all. The fallback for this situation could result in slightly better values during import. The count and for_each values were technically incorrect, since the length is not known to be zero, and the single instance does have a concrete type which we can return.
jbardin
force-pushed
the
jbardin/import-plan-new
branch
from
4ff0fd8 to
041d9d3
Compare
alisdair
approved these changes
Oct 4, 2022
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because import does not yet plan new instances as part of the import process, we can end up evaluating references to resources which have no state at all, and the fallback for this situation could result in slightly better values. The count and for_each values were technically incorrect, since the length is not known to be zero, so we return a
DynamicValinstead. The single instance case does have a concrete type which we can return as an unknown.This whole process was meant as a step towards a complete import plan, but unfortunately is still contains a few similar edge cases which plagued the original import graph. While these new values will allow more expressions to evaluate correctly (mostly in count/for_each where known-ness is important), there are going to be situations which won't work until we have the complete planned values.
Fixes #31852