prune unused nodes from a destroy plan graph #31858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may need to prune nodes from a full destroy plan graph which cannot be evaluated if there is no current state. Add missing method to nodeExpandPlannableResource to ensure planned resource are handled correctly when pruning nodes.
jbardin
added
the
1.3-backport
alisdair
approved these changes
Sep 23, 2022
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may need to prune nodes from a full destroy plan graph which cannot be evaluated if there is no current state. This is the same method used during apply, however for planning we are only going to encounter evaluation problems during a full destroy, so we can skip the pruning process for normal plans.
Add missing
expandsInstances()method tonodeExpandPlannableResourceto ensure planned resources are handled correctly when pruning nodes.Fixes #31838