Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pre-Plan Run Tasks to Terraform CLI #31617

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

glennsarti
Copy link
Contributor

Prevously the cloud backend would only render post-plan run tasks. Now
that pre-plan tasks are in beta, this commit updates the plan phase to
render pre-plan run tasks. This commit also moves some common code to
the common backend as it will be used by other task stages in the
future.

@glennsarti glennsarti force-pushed the gs/TF-410-add-prep-plan branch from 43d8dbd to 003b5d8 Compare August 11, 2022 03:50
@glennsarti glennsarti marked this pull request as ready for review August 11, 2022 03:50
@glennsarti glennsarti force-pushed the gs/TF-410-add-prep-plan branch from 003b5d8 to 729a2f4 Compare August 11, 2022 03:55
@glennsarti glennsarti self-assigned this Aug 11, 2022
@glennsarti
Copy link
Contributor Author

Example run;

image

@glennsarti
Copy link
Contributor Author

Rebased due to changelog merge conflict

Copy link
Contributor

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Prevously the cloud backend would only render post-plan run tasks. Now
that pre-plan tasks are in beta, this commit updates the plan phase to
render pre-plan run tasks.  This commit also moves some common code to
the common backend as it will be used by other task stages in the
future.
@glennsarti glennsarti force-pushed the gs/TF-410-add-prep-plan branch from bb32bcf to 8562f8a Compare August 18, 2022 02:09
@glennsarti
Copy link
Contributor Author

Rebased due to changelog merge conflict

@glennsarti
Copy link
Contributor Author

@brandonc I can't merge this (I don't have rights)

@brandonc brandonc merged commit 76d40d2 into hashicorp:main Aug 18, 2022
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants