getproviders: account for occasionally missing Host
header in errors
#31542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #30810 and #29298
They each aimed to add more context to the following error messages:
Based on some recent CI runs, it became clear that
Request.Host
may sometimes be empty, which results in the following error message:See https://github.com/hashicorp/terraform-ls/runs/7574713438?check_suite_focus=true#step:6:46
I don't actually know under what exact circumstances would the
Host
be missing. It is clear however from reading the implementation ofnet/http.Request.Write()
that this may happen.I therefore propose to mimic what the stdlib does here, to ensure we always expose the host in the error message.
I expect #31524 can be updated to take advantage of this too, once this PR is merged.