providercache: include host in provider installation error #31524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-include-host-in-prov-install-err
branch
from
db88a3a to
275f894
Compare
kmoe
approved these changes
Jul 29, 2022
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by issues of the nature described in #31516 which we also noticed as part of our regular CI runs recently which runs
terraform initfor all ~250 official+verified providers.https://github.com/hashicorp/terraform-ls/runs/7467545895?check_suite_focus=true#step:6:43
It aims to turn the following error:
into
The aim here is to communicate the fact that (often) such networking issues are between the user and GitHub, rather than the Terraform Registry - and if it is in fact the Registry then should allow us (and the user) to tell the errors apart.
This is similar to #30810