json-output: Fix unknowns for tuples and sets #31236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON output for sequences previously omitted unknown values for tuples and sets, which made it impossible to interpret the corresponding unknown marks. For example, consider this resource:
This would previously be encoded in JSON as:
That is, the timestamp value would be omitted from the output altogether, while the corresponding unknown marks would include a value for each of the set members.
This commit changes the behaviour to:
This aligns tuples and sets with the prior behaviour for lists, and makes it clear which elements are known and which are unknown.
I consider this a bug fix, as the prior output was not usable, and I believe this behaviour is correct.