Fix diff of list of objects #22695
Merged
Fix diff of list of objects #22695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hashicorp#21473 The previous code incorrectly compared the old value of the object with a new value at the same index, even if the value was common to both lists but occurs in old later. This caused confusing and wrong diffs if you deleted an object in the middle of a list.
|
Hi @tmccombs! Thanks for tracking this down and working on the fix. This fix makes sense to me! It's interesting that we apparently previously had a test demonstrating the incorrect behavior, but I'm glad you spotted this incorrect behavior nonetheless and fixed it. I'm going to merge this now for inclusion in the next release. Sorry for the delayed response. Thanks again! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21473
The previous code incorrectly compared the old value of the object with
a new value at the same index, even if the value was common to both
lists but occurs in old later. This caused confusing and wrong diffs if
you deleted an object in the middle of a list.