GKE Container Node Pool with sandbox type of gvisor missing label "sandbox.gke.io/runtime" = "gvisor"

[ghost]

This issue was originally opened by @vugardzhamalov as hashicorp/terraform#22434. It was migrated here as a result of the provider split. The original body of the issue is below.

---

Hi there,

Terraform Version: 0.12.6
Terraform Resource: google_container_node_pool
Sandbox type: gvisor

It seems that unless explicitly declared in the labels list of container node pool this will not be declared automatically (but I suspect it is expected to be there). My current guess that this might affect node taint as well... But I am not certain.

The missing label is: "sandbox.gke.io/runtime" = "gvisor". If I don't declare it explicitly, this is what I see in my 'terraform plan' output.

`~ node_config {
~ labels = { # forces replacement
- "sandbox.gke.io/runtime" = "gvisor" -> null
}

• taint {
  - effect = "NO_SCHEDULE" -> null
  - key = "sandbox.gke.io/runtime" -> null
  - value = "gvisor" -> null
  }`

Explicit declaration of this label fixes the issue for me!

[tysen]

The labels field is optional and will take on the value returned by the API unless explicitly declared. If it's declared in your config, you'll have to supply this label, as you discovered.

[vugardzhamalov]

Thanks @tysen,

I could be wrong on this one (I try to re-deploy the resource as soon as I have a moment), but as far as I can remember explicit declaration of "sandbox.gke.io/runtime" = "gvisor" label prior to 'apply' might result in terraform refusing to apply it... This is why you might be left with only one option - declare it explicitly (and apply it) afterwards.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!