Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_kinesis_firehose_delivery_stream: Add support for s3 custom prefixes #7953

Closed
mwarkentin opened this issue Mar 15, 2019 · 7 comments
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@mwarkentin
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Kinesis Firehose support for custom prefixes in s3 was recently announced.

Documentation: https://docs.aws.amazon.com/firehose/latest/dev/s3-prefixes.html

New or Affected Resource(s)

  • Update to aws_kinesis_firehose_delivery_stream.extended_s3_configuration

Potential Terraform Configuration

resource "aws_kinesis_firehose_delivery_stream" "extended_s3_stream" {
  name        = "terraform-kinesis-firehose-extended-s3-test-stream"
  destination = "extended_s3"

  extended_s3_configuration {
    role_arn   = "${aws_iam_role.firehose_role.arn}"
    bucket_arn = "${aws_s3_bucket.bucket.arn}"

    prefix = "myPrefix/year=!{timestamp:yyyy}/month=!{timestamp:MM}/day=!{timestamp:dd}/hour=!{timestamp:HH}/"
  }
}

References

@mwarkentin mwarkentin added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 15, 2019
@mwarkentin
Copy link
Contributor Author

CC @ewbankkit as you seem interested in various firehose things. :)

@deepakbshetty
Copy link
Contributor

@bflad, Any chances of this feature getting implemented soon ?

@Obsecurus
Copy link

@bflad any updates on this? Seems like #11229 fixes. The language server already supports this which lead me down the path of trying to implement it only to find it hasn't been merged.

@JeffAshton
Copy link
Contributor

@Obsecurus, Been sadly waiting on this one for 3 months. :(

@anGie44
Copy link
Contributor

anGie44 commented Dec 23, 2021

Hi @mwarkentin @deepakbshetty @Obsecurus @JeffAshton , #11229 has been merged, addressing the missing error_output_prefix in the root-level s3_configuration block as well as in the nested s3_backup_configuration in redshift_configuration and extended_s3_configuration. So i believe that completes the remaining item for this issue. I'm going to go ahead and close this but if y'all feel there's something left to address please reach out!

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
Development

No branches or pull requests

6 participants