fix: update validation for throughput capacity

[stefanfreitag]

Description

Update the validation for the argument throughput_capacity when creating an aws_fsx_windows_file_system resource.

The current validation allows values between 8 and 2048. Actually,

• only a small subset of values inside this range is allowed
• larger values are also fine in some regions.

Here an example output when a value of 2040 is specified:

 Error: creating FSx for Windows File Server File System: operation error FSx: CreateFileSystem, https response error StatusCode: 400, RequestID: 39b44ab9-daca-46f1-a6c0-ec8a64c639d1, BadRequest: Invalid desired throughput capacity value provided: 2040 MB/s. Please refer to the performance guide (https://docs.aws.amazon.com/fsx/latest/WindowsGuide/performance.html) when selecting a value.

The documentation is updated and no longer mentions in power of 2 increments as this in no longer true for values > 2048.

Relations

Closes #40289

References

• Announcement
• FSx Windows - Performance overview
  mentioning region specific maximum value for the throughput capacity.

  Amazon FSx file systems provide up to 2 GB/s and 80,000 IOPS in all AWS Regions where Amazon FSx is available, and 12 GB/s of throughput and 400,000 IOPS in US East (N. Virginia), US West (Oregon), US East (Ohio), Europe (Ireland), Asia Pacific (Tokyo), and Asia Pacific (Singapore).

Output from Acceptance Testing

TBD

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

Options when creating Amazon FSx for Windows File Server via Console:

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFSxWindowsFileSystem_throughputCapacity' PKG=fsx
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/fsx/... -v -count 1 -parallel 20  -run=TestAccFSxWindowsFileSystem_throughputCapacity -timeout 360m
2024/12/06 09:32:07 Initializing Terraform AWS Provider...
=== RUN   TestAccFSxWindowsFileSystem_throughputCapacity
=== PAUSE TestAccFSxWindowsFileSystem_throughputCapacity
=== CONT  TestAccFSxWindowsFileSystem_throughputCapacity
--- PASS: TestAccFSxWindowsFileSystem_throughputCapacity (2817.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	2823.316s

[johnsonaj]

LGTM 🚀

[ewbankkit]

@stefanfreitag Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.