Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_eks_cluster: Add support for EKS Auto Mode #40370

Merged
merged 17 commits into from
Dec 3, 2024

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Dec 1, 2024

Description

  • Add support for EKS Auto Mode

⚠️ Requires #40380

Relations

Closes #40373.

References

Output from Acceptance Testing

make testacc PKG=eks TESTS=TestAccEKSCluster_ComputeConfig
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_ComputeConfig'  -timeout 360m
2024/12/01 09:32:13 Initializing Terraform AWS Provider...
=== RUN   TestAccEKSCluster_ComputeConfig
=== PAUSE TestAccEKSCluster_ComputeConfig
=== CONT  TestAccEKSCluster_ComputeConfig
--- PASS: TestAccEKSCluster_ComputeConfig (929.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	936.338s

Copy link

github-actions bot commented Dec 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented Dec 1, 2024

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/eks Issues and PRs that pertain to the eks service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Dec 1, 2024
@bryantbiggs bryantbiggs marked this pull request as ready for review December 2, 2024 15:40
@bryantbiggs bryantbiggs requested a review from a team as a code owner December 2, 2024 15:40
@gdavison gdavison self-assigned this Dec 2, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 2, 2024
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed a comment when reviewing

website/docs/r/eks_cluster.html.markdown Outdated Show resolved Hide resolved
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Dec 2, 2024
@gdavison gdavison merged commit 0943f5b into hashicorp:main Dec 3, 2024
42 checks passed
@github-actions github-actions bot added this to the v5.79.0 milestone Dec 3, 2024
@bryantbiggs bryantbiggs deleted the feat/eks-auto-mode branch December 3, 2024 00:27
Copy link

github-actions bot commented Dec 3, 2024

This functionality has been released in v5.79.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon EKS Auto Mode
4 participants