-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
names.GlobalRegionID
-> endpoints.AwsGlobalRegionID
#40339
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
… in AWS Dedicated Local Zones.
…' in 'us-east-1' (#39366).
…m: s3:PutObjectAcl on resource: "..." because public access control lists (ACLs) are blocked by the BlockPublicAcls block public access setting'.
…uckets correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=s3 TESTS="TestAccS3Bucket.*_directoryBucket"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Bucket.*_directoryBucket' -timeout 360m
2024/12/03 16:35:31 Initializing Terraform AWS Provider...
--- PASS: TestAccS3BucketWebsiteConfiguration_directoryBucket (13.23s)
--- PASS: TestAccS3BucketLogging_directoryBucket (13.70s)
--- PASS: TestAccS3BucketObjectLockConfiguration_directoryBucket (14.16s)
--- PASS: TestAccS3BucketPublicAccessBlock_directoryBucket (14.16s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_directoryBucket (14.78s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_directoryBucket (14.89s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_directoryBucket (14.89s)
--- PASS: TestAccS3BucketNotification_directoryBucket (15.22s)
--- PASS: TestAccS3BucketOwnershipControls_directoryBucket (16.38s)
--- PASS: TestAccS3BucketAccelerateConfiguration_directoryBucket (16.38s)
--- PASS: TestAccS3BucketCORSConfiguration_directoryBucket (16.54s)
--- PASS: TestAccS3BucketInventory_directoryBucket (16.64s)
--- PASS: TestAccS3BucketVersioning_directoryBucket (16.67s)
--- PASS: TestAccS3BucketACL_directoryBucket (16.69s)
--- PASS: TestAccS3BucketReplicationConfiguration_directoryBucket (17.50s)
--- PASS: TestAccS3BucketMetric_directoryBucket (17.99s)
--- PASS: TestAccS3BucketPolicy_directoryBucket (21.87s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_directoryBucket (21.88s)
--- PASS: TestAccS3BucketLifecycleConfiguration_directoryBucket (71.49s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 76.677s
This functionality has been released in v5.80.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Missing constant replacement, which after some "simple testing" uncovered problems with S3 directory buckets in
us-east-1
.Relations
Closes #40383.
Problems with
bucketNameTypeFor
introduced in #35402.Relates #40335.
Relates #39874.
Relates #39873.
Relates hashicorp/aws-sdk-go-base#1176.
Output from Acceptance Testing
us-west-2