Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: r/ebs_snapshot_copy new completion_duration_minutes argument. Time-based Copy for EBS Snapshots #40336

Merged

Conversation

alexbacchin
Copy link
Contributor

Description

Adds new argument to support time-based Copy for EBS Snapshots.

Relations

Closes #40329

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CopySnapshot.html

Output from Acceptance Testing

% make testacc TESTS=TestAccEC2EBSSnapshotCopy_withCompletionDurationMinutes PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EBSSnapshotCopy_withCompletionDurationMinutes'  -timeout 360m
2024/11/28 09:11:51 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2EBSSnapshotCopy_withCompletionDurationMinutes
=== PAUSE TestAccEC2EBSSnapshotCopy_withCompletionDurationMinutes
=== CONT  TestAccEC2EBSSnapshotCopy_withCompletionDurationMinutes
--- PASS: TestAccEC2EBSSnapshotCopy_withCompletionDurationMinutes (153.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        153.284s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. needs-triage Waiting for first response or review from a maintainer. labels Nov 27, 2024
@alexbacchin alexbacchin marked this pull request as ready for review November 28, 2024 05:23
@alexbacchin alexbacchin requested a review from a team as a code owner November 28, 2024 05:23
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 5, 2024
@ewbankkit ewbankkit self-assigned this Dec 5, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 5, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2EBSSnapshotCopy_' PKG=ec2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2EBSSnapshotCopy_ -timeout 360m
2024/12/05 11:53:46 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2EBSSnapshotCopy_basic
=== PAUSE TestAccEC2EBSSnapshotCopy_basic
=== RUN   TestAccEC2EBSSnapshotCopy_disappears
=== PAUSE TestAccEC2EBSSnapshotCopy_disappears
=== RUN   TestAccEC2EBSSnapshotCopy_tags
=== PAUSE TestAccEC2EBSSnapshotCopy_tags
=== RUN   TestAccEC2EBSSnapshotCopy_withDescription
=== PAUSE TestAccEC2EBSSnapshotCopy_withDescription
=== RUN   TestAccEC2EBSSnapshotCopy_withRegions
=== PAUSE TestAccEC2EBSSnapshotCopy_withRegions
=== RUN   TestAccEC2EBSSnapshotCopy_withKMS
=== PAUSE TestAccEC2EBSSnapshotCopy_withKMS
=== RUN   TestAccEC2EBSSnapshotCopy_storageTier
=== PAUSE TestAccEC2EBSSnapshotCopy_storageTier
=== RUN   TestAccEC2EBSSnapshotCopy_withCompletionDurationMinutes
=== PAUSE TestAccEC2EBSSnapshotCopy_withCompletionDurationMinutes
=== CONT  TestAccEC2EBSSnapshotCopy_basic
=== CONT  TestAccEC2EBSSnapshotCopy_withRegions
=== CONT  TestAccEC2EBSSnapshotCopy_storageTier
--- PASS: TestAccEC2EBSSnapshotCopy_withRegions (67.89s)
=== CONT  TestAccEC2EBSSnapshotCopy_withCompletionDurationMinutes
--- PASS: TestAccEC2EBSSnapshotCopy_basic (125.13s)
=== CONT  TestAccEC2EBSSnapshotCopy_withKMS
--- PASS: TestAccEC2EBSSnapshotCopy_storageTier (129.83s)
=== CONT  TestAccEC2EBSSnapshotCopy_tags
--- PASS: TestAccEC2EBSSnapshotCopy_withKMS (64.20s)
=== CONT  TestAccEC2EBSSnapshotCopy_withDescription
--- PASS: TestAccEC2EBSSnapshotCopy_withCompletionDurationMinutes (141.54s)
=== CONT  TestAccEC2EBSSnapshotCopy_disappears
--- PASS: TestAccEC2EBSSnapshotCopy_tags (81.77s)
--- PASS: TestAccEC2EBSSnapshotCopy_withDescription (64.49s)
--- PASS: TestAccEC2EBSSnapshotCopy_disappears (91.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	305.598s

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit ee988f4 into hashicorp:main Dec 5, 2024
42 checks passed
@github-actions github-actions bot added this to the v5.81.0 milestone Dec 5, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 12, 2024
Copy link

This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time-based Copy for EBS Snapshots
3 participants