Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tagging tests for bedrock #40305

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Adds tagging tests for bedrock #40305

merged 7 commits into from
Dec 3, 2024

Conversation

gdavison
Copy link
Contributor

Description

Adds tagging tests for the bedrock service.

Output from Acceptance Testing

% make testacc PKG=bedrock TESTS=TestAccBedrockGuardrail_tags

--- PASS: TestAccBedrockGuardrail_tags_DefaultTags_emptyResourceTag (52.74s)
--- PASS: TestAccBedrockGuardrail_tags_DefaultTags_nullNonOverlappingResourceTag (54.69s)
--- PASS: TestAccBedrockGuardrail_tags_ComputedTag_OnCreate (57.49s)
--- PASS: TestAccBedrockGuardrail_tags_EmptyMap (59.54s)
--- PASS: TestAccBedrockGuardrail_tags_DefaultTags_nullOverlappingResourceTag (60.34s)
--- PASS: TestAccBedrockGuardrail_tags_DefaultTags_emptyProviderOnlyTag (60.95s)
--- PASS: TestAccBedrockGuardrail_tags_DefaultTags_updateToResourceOnly (73.38s)
--- PASS: TestAccBedrockGuardrail_tags_EmptyTag_OnUpdate_Replace (76.00s)
--- PASS: TestAccBedrockGuardrail_tags_EmptyTag_OnCreate (82.51s)
--- PASS: TestAccBedrockGuardrail_tags_null (34.69s)
--- PASS: TestAccBedrockGuardrail_tags_AddOnUpdate (89.45s)
--- PASS: TestAccBedrockGuardrail_tags_IgnoreTags_Overlap_ResourceTag (94.92s)
--- PASS: TestAccBedrockGuardrail_tags_DefaultTags_updateToProviderOnly (100.46s)
--- PASS: TestAccBedrockGuardrail_tags_EmptyTag_OnUpdate_Add (102.08s)
--- PASS: TestAccBedrockGuardrail_tags_DefaultTags_nonOverlapping (102.38s)
--- PASS: TestAccBedrockGuardrail_tags_DefaultTags_overlapping (103.07s)
--- PASS: TestAccBedrockGuardrail_tags (112.15s)
--- PASS: TestAccBedrockGuardrail_tags_DefaultTags_providerOnly (117.30s)
--- PASS: TestAccBedrockGuardrail_tags_ComputedTag_OnUpdate_Replace (194.35s)
--- PASS: TestAccBedrockGuardrail_tags_ComputedTag_OnUpdate_Add (267.69s)
--- PASS: TestAccBedrockGuardrail_tags_IgnoreTags_Overlap_DefaultTag (1141.72s)
% make testacc PKG=bedrock TESTS='TestAccBedrock_serial/CustomModel/tags'

--- PASS: TestAccBedrock_serial (1389.88s)
    --- PASS: TestAccBedrock_serial/CustomModel (1389.88s)
        --- PASS: TestAccBedrock_serial/CustomModel/tags (1389.88s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/AddOnUpdate (64.89s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/EmptyTag_OnUpdate_Replace (62.42s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/DefaultTags_updateToProviderOnly (70.97s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/DefaultTags_nullNonOverlappingResourceTag (43.30s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/basic (126.83s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/EmptyMap (62.27s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/DefaultTags_overlapping (116.91s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/DefaultTags_updateToResourceOnly (55.75s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/DefaultTags_emptyResourceTag (62.73s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/ComputedTag_OnUpdate_Add (56.77s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/ComputedTag_OnUpdate_Replace (66.21s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/EmptyTag_OnCreate (55.55s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/DefaultTags_providerOnly (78.95s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/DefaultTags_nonOverlapping (103.21s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/null (61.34s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/EmptyTag_OnUpdate_Add (65.30s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/DefaultTags_nullOverlappingResourceTag (55.00s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/ComputedTag_OnCreate (54.48s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/IgnoreTags_Overlap_DefaultTag (60.95s)
            --- PASS: TestAccBedrock_serial/CustomModel/tags/IgnoreTags_Overlap_ResourceTag (66.02s)

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/bedrock Issues and PRs that pertain to the bedrock service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 26, 2024
@gdavison gdavison marked this pull request as ready for review December 2, 2024 19:23
@gdavison gdavison requested a review from a team as a code owner December 2, 2024 19:23
ewbankkit
ewbankkit previously approved these changes Dec 3, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison dismissed ewbankkit’s stale review December 3, 2024 17:40

The merge-base changed after approval.

@gdavison gdavison enabled auto-merge December 3, 2024 18:02
jar-b
jar-b previously approved these changes Dec 3, 2024
@gdavison gdavison dismissed jar-b’s stale review December 3, 2024 18:16

The merge-base changed after approval.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit 92558c0 into main Dec 3, 2024
36 checks passed
@gdavison gdavison deleted the td-bedrock-tags branch December 3, 2024 18:30
@github-actions github-actions bot added this to the v5.80.0 milestone Dec 3, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

This functionality has been released in v5.80.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jan 4, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/bedrock Issues and PRs that pertain to the bedrock service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants