add initial codeconnections resources

[silvaalbert]

Description

This PR adds aws_codeconnections_connection and aws_codeconnections_host resources. While there are still resources to be developed for CodeConnections, these 2 are the main ones needed to replace CodeStar connections.

Relations

Relates #36671

References

https://docs.aws.amazon.com/codeconnections/latest/APIReference/API_CreateConnection.html
https://docs.aws.amazon.com/codeconnections/latest/APIReference/API_CreateHost.html

Output from Acceptance Testing

make testacc TESTS=TestAccCodeConnectionsConnection_ PKG=codeconnections 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codeconnections/... -v -count 1 -parallel 20 -run='TestAccCodeConnectionsConnection_'  -timeout 360m
2024/11/25 14:23:00 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeConnectionsConnection_basic
=== PAUSE TestAccCodeConnectionsConnection_basic
=== RUN   TestAccCodeConnectionsConnection_hostARN
=== PAUSE TestAccCodeConnectionsConnection_hostARN
=== RUN   TestAccCodeConnectionsConnection_disappears
=== PAUSE TestAccCodeConnectionsConnection_disappears
=== RUN   TestAccCodeConnectionsConnection_tags
=== PAUSE TestAccCodeConnectionsConnection_tags
=== CONT  TestAccCodeConnectionsConnection_basic
=== CONT  TestAccCodeConnectionsConnection_disappears
=== CONT  TestAccCodeConnectionsConnection_tags
=== CONT  TestAccCodeConnectionsConnection_hostARN
--- PASS: TestAccCodeConnectionsConnection_disappears (13.72s)
--- PASS: TestAccCodeConnectionsConnection_basic (15.66s)
--- PASS: TestAccCodeConnectionsConnection_hostARN (16.42s)
--- PASS: TestAccCodeConnectionsConnection_tags (29.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeconnections	33.707s

make testacc TESTS=TestAccCodeConnectionsHost_ PKG=codeconnections
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codeconnections/... -v -count 1 -parallel 20 -run='TestAccCodeConnectionsHost_'  -timeout 360m
2024/11/25 14:25:33 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeConnectionsHost_basic
=== PAUSE TestAccCodeConnectionsHost_basic
=== RUN   TestAccCodeConnectionsHost_disappears
=== PAUSE TestAccCodeConnectionsHost_disappears
=== RUN   TestAccCodeConnectionsHost_vpc
=== PAUSE TestAccCodeConnectionsHost_vpc
=== RUN   TestAccCodeConnectionsHost_tags
=== PAUSE TestAccCodeConnectionsHost_tags
=== CONT  TestAccCodeConnectionsHost_basic
=== CONT  TestAccCodeConnectionsHost_vpc
=== CONT  TestAccCodeConnectionsHost_disappears
=== CONT  TestAccCodeConnectionsHost_tags
--- PASS: TestAccCodeConnectionsHost_disappears (12.09s)
--- PASS: TestAccCodeConnectionsHost_basic (14.09s)
=== NAME  TestAccCodeConnectionsHost_tags
    host_test.go:128: Step 3/4 error: Error running apply: exit status 1

        Error: Provider produced inconsistent result after apply

        When applying changes to aws_codeconnections_host.test, provider
        "provider[\"registry.terraform.io/hashicorp/aws\"]" produced an unexpected
        new value: .tags["key1"]: was cty.StringVal("value1updated"), but now
        cty.StringVal("value1").

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.

        Error: Provider produced inconsistent result after apply

        When applying changes to aws_codeconnections_host.test, provider
        "provider[\"registry.terraform.io/hashicorp/aws\"]" produced an unexpected
        new value: .tags: element "key2" has vanished.

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.

        Error: Provider produced inconsistent result after apply

        When applying changes to aws_codeconnections_host.test, provider
        "provider[\"registry.terraform.io/hashicorp/aws\"]" produced an unexpected
        new value: .tags_all["key1"]: was cty.StringVal("value1updated"), but now
        cty.StringVal("value1").

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.

        Error: Provider produced inconsistent result after apply

        When applying changes to aws_codeconnections_host.test, provider
        "provider[\"registry.terraform.io/hashicorp/aws\"]" produced an unexpected
        new value: .tags_all: element "key2" has vanished.

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.
--- FAIL: TestAccCodeConnectionsHost_tags (16.90s)
--- PASS: TestAccCodeConnectionsHost_vpc (547.61s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/codeconnections	552.182s
FAIL
make: *** [testacc] Error 1

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[silvaalbert]

Hello @ewbankkit! I've put this PR together - but - I've hit a roadblock with a tagging issue on the aws_codeconnection_host resource. tldr; the tags set appropriately in AWS, but the state does not update (you can see the failed test above). Given I don't have a lot of depth on how the new framework handles tagging, I haven't been able to troubleshoot effectively, despite spending time trying different things. Would you be able to take a look? Thank you!

[silvaalbert]

Thanks for your assistance @ewbankkit! I think this PR is now ready for final review/merging.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeConnectionsConnection_\|TestAccCodeConnectionsHost_' PKG=codeconnections ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codeconnections/... -v -count 1 -parallel 3  -run=TestAccCodeConnectionsConnection_\|TestAccCodeConnectionsHost_ -timeout 360m
2024/12/03 12:47:38 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeConnectionsConnection_basic
=== PAUSE TestAccCodeConnectionsConnection_basic
=== RUN   TestAccCodeConnectionsConnection_hostARN
=== PAUSE TestAccCodeConnectionsConnection_hostARN
=== RUN   TestAccCodeConnectionsConnection_disappears
=== PAUSE TestAccCodeConnectionsConnection_disappears
=== RUN   TestAccCodeConnectionsConnection_tags
=== PAUSE TestAccCodeConnectionsConnection_tags
=== RUN   TestAccCodeConnectionsHost_basic
=== PAUSE TestAccCodeConnectionsHost_basic
=== RUN   TestAccCodeConnectionsHost_disappears
=== PAUSE TestAccCodeConnectionsHost_disappears
=== RUN   TestAccCodeConnectionsHost_vpc
=== PAUSE TestAccCodeConnectionsHost_vpc
=== RUN   TestAccCodeConnectionsHost_tags
=== PAUSE TestAccCodeConnectionsHost_tags
=== CONT  TestAccCodeConnectionsConnection_basic
=== CONT  TestAccCodeConnectionsHost_basic
=== CONT  TestAccCodeConnectionsConnection_disappears
--- PASS: TestAccCodeConnectionsConnection_disappears (11.73s)
=== CONT  TestAccCodeConnectionsConnection_tags
--- PASS: TestAccCodeConnectionsConnection_basic (13.59s)
=== CONT  TestAccCodeConnectionsConnection_hostARN
--- PASS: TestAccCodeConnectionsHost_basic (13.76s)
=== CONT  TestAccCodeConnectionsHost_vpc
--- PASS: TestAccCodeConnectionsConnection_hostARN (13.82s)
=== CONT  TestAccCodeConnectionsHost_tags
--- PASS: TestAccCodeConnectionsConnection_tags (27.51s)
=== CONT  TestAccCodeConnectionsHost_disappears
--- PASS: TestAccCodeConnectionsHost_disappears (10.70s)
--- PASS: TestAccCodeConnectionsHost_tags (27.45s)
--- PASS: TestAccCodeConnectionsHost_vpc (541.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeconnections	560.267s

[jar-b]

LGTM 🚀

[ewbankkit]

@silvaalbert Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.80.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.