r/aws_ecs_service: add availability_zone_rebalancing attribute
#40225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
johnsonaj
changed the title
availability_zone_rebalancing attribute
jar-b
previously approved these changes
Nov 21, 2024
There was a problem hiding this comment.
LGTM 🎉
% make testacc PKG=ecs TESTS=TestAccECSService_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_' -timeout 360m
--- PASS: TestAccECSService_iamRole (47.19s)
=== CONT TestAccECSService_familyAndRevision
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (51.53s)
=== CONT TestAccECSService_DeploymentValues_minZeroMaxOneHundred
--- PASS: TestAccECSService_clusterName (71.72s)
=== CONT TestAccECSService_VolumeConfiguration_throughputTypeChange
--- PASS: TestAccECSService_deploymentCircuitBreaker (71.84s)
=== CONT TestAccECSService_DeploymentValues_basic
--- PASS: TestAccECSService_replicaSchedulingStrategy (72.58s)
=== CONT TestAccECSService_VolumeConfiguration_update
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (72.91s)
=== CONT TestAccECSService_VolumeConfiguration_tagSpecifications
--- PASS: TestAccECSService_basic (82.05s)
=== CONT TestAccECSService_alarmsUpdate
--- PASS: TestAccECSService_VolumeConfiguration_basic (83.62s)
=== CONT TestAccECSService_PlacementStrategy_missing
--- PASS: TestAccECSService_PlacementStrategy_missing (1.03s)
=== CONT TestAccECSService_alarmsAdd
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (59.79s)
=== CONT TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSService_forceNewDeploymentTriggers (111.98s)
=== CONT TestAccECSService_DeploymentControllerType_external
--- PASS: TestAccECSService_forceNewDeployment (112.79s)
=== CONT TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
--- PASS: TestAccECSService_familyAndRevision (67.23s)
=== CONT TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (131.61s)
=== CONT TestAccECSService_PlacementStrategy_basic
--- PASS: TestAccECSService_VolumeConfiguration_tagSpecifications (60.38s)
=== CONT TestAccECSService_CapacityProviderStrategy_update
--- PASS: TestAccECSService_DeploymentValues_basic (63.14s)
=== CONT TestAccECSService_LaunchTypeEC2_network
--- PASS: TestAccECSService_LaunchTypeFargate_basic (142.39s)
=== CONT TestAccECSService_ServiceConnect_remove
--- PASS: TestAccECSService_DeploymentControllerType_external (33.25s)
=== CONT TestAccECSService_CapacityProviderStrategy_forceNewDeployment
--- PASS: TestAccECSService_ServiceRegistries_basic (151.21s)
=== CONT TestAccECSService_DaemonSchedulingStrategy_basic
--- PASS: TestAccECSService_alarmsUpdate (70.88s)
=== CONT TestAccECSService_AvailabilityZoneRebalancing
--- PASS: TestAccECSService_VolumeConfiguration_throughputTypeChange (83.14s)
=== CONT TestAccECSService_Tags_managed
--- PASS: TestAccECSService_ServiceRegistries_container (161.82s)
=== CONT TestAccECSService_Tags_propagate
--- PASS: TestAccECSService_alarmsAdd (79.91s)
=== CONT TestAccECSService_Tags_basic
--- PASS: TestAccECSService_PlacementConstraints_basic (69.39s)
=== CONT TestAccECSService_disappears
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (182.34s)
=== CONT TestAccECSService_executeCommand
--- PASS: TestAccECSService_VolumeConfiguration_update (111.62s)
=== CONT TestAccECSService_PlacementStrategy_unnormalized
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (38.77s)
=== CONT TestAccECSService_ServiceConnect_full
--- PASS: TestAccECSService_Tags_managed (59.82s)
=== CONT TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
--- PASS: TestAccECSService_PlacementStrategy_basic (97.20s)
=== CONT TestAccECSService_ServiceConnect_ingressPortOverride
--- PASS: TestAccECSService_Tags_propagate (78.51s)
=== CONT TestAccECSService_ServiceRegistries_removal
--- PASS: TestAccECSService_LaunchTypeEC2_network (106.73s)
=== CONT TestAccECSService_ServiceConnect_basic
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (60.27s)
=== CONT TestAccECSService_ServiceConnect_tls_with_empty_timeout
--- PASS: TestAccECSService_Tags_basic (81.19s)
=== CONT TestAccECSService_ServiceRegistries_changes
--- PASS: TestAccECSService_AvailabilityZoneRebalancing (96.32s)
=== CONT TestAccECSService_basicImport
--- PASS: TestAccECSService_executeCommand (69.95s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (142.07s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (122.88s)
--- PASS: TestAccECSService_alb (281.24s)
--- PASS: TestAccECSService_multipleTargetGroups (283.71s)
--- PASS: TestAccECSService_loadBalancerChanges (284.35s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (285.18s)
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (330.35s)
--- PASS: TestAccECSService_ServiceConnect_remove (189.71s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (209.41s)
--- PASS: TestAccECSService_ServiceConnect_full (166.45s)
--- PASS: TestAccECSService_disappears (189.85s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (174.17s)
--- PASS: TestAccECSService_ServiceConnect_basic (148.10s)
--- PASS: TestAccECSService_ServiceRegistries_removal (152.19s)
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (165.78s)
--- PASS: TestAccECSService_ServiceConnect_tls_with_empty_timeout (165.43s)
--- PASS: TestAccECSService_basicImport (184.31s)
--- PASS: TestAccECSService_ServiceRegistries_changes (273.10s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (467.82s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 587.146s
|
@dani-chmb thank you for the contribution! 🎉 |
jar-b
approved these changes
Nov 21, 2024
|
This functionality has been released in v5.77.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
github-actions
bot
removed
the
prioritized
nina-nee
added a commit
to nina-nee/terraform-provider-aws
that referenced
this pull request
Dec 11, 2024
…have a default An attributed availability_zone_rebalancing that was introduced in PR hashicorp#40225 is defined as an optional, but also has a default value. For configurations where this flag is not defined, plan with `refresh=false` results in a change that would add this attribute to the state - which is not what "optional" should mean. This is to address hashicorp#40349
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for availability_zone_rebalancing to aws_ecs_service
Relations
Closes #40221
References
Output from Acceptance Testing