-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_ecs_service: Add versionConsistency
support to container_definitions
#40216
Conversation
…and the AWS Console does not set it.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccECSTaskDefinition_' PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run=TestAccECSTaskDefinition_ -timeout 360m
2024/11/20 14:29:07 Initializing Terraform AWS Provider...
--- PASS: TestAccECSTaskDefinition_invalidContainerDefinition (4.09s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (23.63s)
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (30.84s)
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (30.89s)
--- PASS: TestAccECSTaskDefinition_runtimePlatform (33.34s)
--- PASS: TestAccECSTaskDefinition_executionRole (35.40s)
--- PASS: TestAccECSTaskDefinition_taskRoleARN (38.57s)
--- PASS: TestAccECSTaskDefinition_ipcMode (38.70s)
--- PASS: TestAccECSTaskDefinition_networkMode (38.91s)
--- PASS: TestAccECSTaskDefinition_pidMode (38.95s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (43.95s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal (49.26s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled (49.67s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (49.74s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (49.78s)
--- PASS: TestAccECSTaskDefinition_proxy (50.51s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (53.63s)
--- PASS: TestAccECSTaskDefinition_basic (57.52s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (37.94s)
--- PASS: TestAccECSTaskDefinition_configuredAtLaunch (35.72s)
--- PASS: TestAccECSTaskDefinition_arrays (38.64s)
--- PASS: TestAccECSTaskDefinition_containerDefinitionDockerLabels (33.68s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (41.86s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (40.91s)
--- PASS: TestAccECSTaskDefinition_scratchVolume (41.10s)
--- PASS: TestAccECSTaskDefinition_Fargate_basic (47.04s)
--- PASS: TestAccECSTaskDefinition_unknownContainerDefinitions (31.96s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (47.34s)
--- PASS: TestAccECSTaskDefinition_containerDefinitionNullPortMapping (37.95s)
--- PASS: TestAccECSTaskDefinition_disappears (58.26s)
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency_nullToEnabled (50.93s)
--- PASS: TestAccECSTaskDefinition_tags (100.25s)
--- PASS: TestAccECSTaskDefinition_constraint (38.82s)
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency_enabledToNull (52.86s)
--- PASS: TestAccECSTaskDefinition_trackLatest (33.91s)
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (54.70s)
--- PASS: TestAccECSTaskDefinition_containerDefinitionVersionConsistency (50.21s)
--- PASS: TestAccECSTaskDefinition_v5590ContainerDefinitionsRegression (83.39s)
--- PASS: TestAccECSTaskDefinition_service (146.20s)
--- PASS: TestAccECSTaskDefinition_containerDefinitionEmptyPortMappings (102.04s)
--- PASS: TestAccECSTaskDefinition_fsxWinFileSystem (3466.65s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 3473.253s
This functionality has been released in v5.77.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add support for
versionConsistency
to thecontainer_definitions
attribute ofaws_ecs_task_definition
Relations
Closes #40202
Output from Acceptance Testing