-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f/Start/Stop DB Instance Resource #40180
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool. Some say it breaks declarative but if people find it useful, I say, 🎉
% make testacc TESTARGS='-run=TestAccRDSInstanceState_' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/rds/... -v -count 1 -parallel 20 -run=TestAccRDSInstanceState_ -timeout 360m
2024/11/19 18:53:05 Initializing Terraform AWS Provider...
=== RUN TestAccRDSInstanceState_basic
=== PAUSE TestAccRDSInstanceState_basic
=== RUN TestAccRDSInstanceState_update
=== PAUSE TestAccRDSInstanceState_update
=== RUN TestAccRDSInstanceState_disappears_Instance
=== PAUSE TestAccRDSInstanceState_disappears_Instance
=== CONT TestAccRDSInstanceState_basic
=== CONT TestAccRDSInstanceState_disappears_Instance
=== CONT TestAccRDSInstanceState_update
--- PASS: TestAccRDSInstanceState_basic (554.67s)
--- PASS: TestAccRDSInstanceState_disappears_Instance (627.12s)
--- PASS: TestAccRDSInstanceState_update (1096.34s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 1100.377s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor suggestions, but I really like the simplicity of the implementation 👍
Co-authored-by: Jared Baker <[email protected]>
Co-authored-by: Jared Baker <[email protected]>
Co-authored-by: Jared Baker <[email protected]>
Co-authored-by: Jared Baker <[email protected]>
Co-authored-by: Jared Baker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After latest:
% make t T=TestAccRDSInstanceState_ K=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstanceState_' -timeout 360m
2024/11/20 12:40:09 Initializing Terraform AWS Provider...
=== RUN TestAccRDSInstanceState_basic
=== PAUSE TestAccRDSInstanceState_basic
=== RUN TestAccRDSInstanceState_update
=== PAUSE TestAccRDSInstanceState_update
=== RUN TestAccRDSInstanceState_disappears_Instance
=== PAUSE TestAccRDSInstanceState_disappears_Instance
=== CONT TestAccRDSInstanceState_basic
=== CONT TestAccRDSInstanceState_disappears_Instance
=== CONT TestAccRDSInstanceState_update
--- PASS: TestAccRDSInstanceState_basic (546.86s)
--- PASS: TestAccRDSInstanceState_disappears_Instance (547.64s)
--- PASS: TestAccRDSInstanceState_update (1099.80s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 1103.763s
This functionality has been released in v5.77.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
New resource to start and stop RDS DB Instance. This follows the previous established pattern with the EC2 Instance resource and the EC2 Instance State resource.
Relations
Closes #29757
References
Output from Acceptance Testing