Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_dynamodb_table: ignore go default value when expanding on_demand_throughput #39784

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

johnsonaj
Copy link
Contributor

Description

During expansion the Go int default value 0 is being included in the request. This happens when either optional attribute max_read_request_units or max_write_request_units is omitted.

Relations

Closes #39760

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccDynamoDBTable_gsi\|TestAccDynamoDBTable_onDemandThroughput\|TestAccDynamoDBTable_basic\|TestAccDynamoDBTable_disappears' PKG=dynamodb

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/dynamodb/... -v -count 1 -parallel 20  -run=TestAccDynamoDBTable_gsi\|TestAccDynamoDBTable_onDemandThroughput\|TestAccDynamoDBTable_basic\|TestAccDynamoDBTable_disappears -timeout 360m
2024/10/17 15:42:16 Initializing Terraform AWS Provider...
--- PASS: TestAccDynamoDBTable_disappears (22.84s)
--- PASS: TestAccDynamoDBTable_basic (23.83s)
--- PASS: TestAccDynamoDBTable_onDemandThroughput (50.64s)
--- PASS: TestAccDynamoDBTable_gsiOnDemandThroughput (56.10s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (56.16s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (384.45s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (715.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	721.810s

@johnsonaj johnsonaj requested a review from a team as a code owner October 17, 2024 21:02
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/dynamodb Issues and PRs that pertain to the dynamodb service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 17, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@johnsonaj johnsonaj merged commit 3fc7ac2 into main Oct 18, 2024
32 checks passed
@johnsonaj johnsonaj deleted the b-dynamodb_table_odt branch October 18, 2024 14:28
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 18, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 18, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2024
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/dynamodb Issues and PRs that pertain to the dynamodb service.
Projects
None yet
2 participants