Add Valkey engine support for ElastiCache resources #39745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
relu
force-pushed
the
f-elasticache-valkey
branch
from
c134486 to
2995833
Compare
chlunde
reviewed
Oct 16, 2024
relu
force-pushed
the
f-elasticache-valkey
branch
from
2995833 to
3650d42
Compare
|
I'm in the process of running the acceptance tests and will post updates to the PR as they are completed. I'm going to run for the following namespaces: |
Fixes hashicorp#39641 Signed-off-by: Aurel Canciu <[email protected]>
relu
force-pushed
the
f-elasticache-valkey
branch
from
3650d42 to
834404e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
…utes The respective attributes are already checked using `resource.TestCheckResourceAttr`. Signed-off-by: Aurel Canciu <[email protected]>
This was a bit more tricky because AWS will allow modify requests for the replication group when only the engine attribute is changed but this actually ends up resulting in no actual upgrade operation. What I've discovered is that for this process to be successful, the engine_version attribute needs to be explicitly provided as well. Signed-off-by: Aurel Canciu <[email protected]>
…ion_enabled This was uncovered in TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID where transit_encryption_enabled was set on replication groups that were added to the global replication group. The attribute should not be set in this scenario. Signed-off-by: Aurel Canciu <[email protected]>
…ache Fixes hashicorp#39711 Signed-off-by: Aurel Canciu <[email protected]>
Signed-off-by: Aurel Canciu <[email protected]>
ewbankkit
added
enhancement
github-actions
bot
added
the
prioritized
|
@ewbankkit I've noticed you're attempting to add the feature to the My bad, I should have documented this finding on the PR. |
|
Thanks @relu for the implementation. I have updated a The only catch to update existing resources is that we first need to add a separate Hope this gets merged soon. |
ewbankkit
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccElastiCacheCluster_' PKG=elasticache ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elasticache/... -v -count 1 -parallel 4 -run=TestAccElastiCacheCluster_ -timeout 720m
2024/10/21 08:06:11 Initializing Terraform AWS Provider...
=== RUN TestAccElastiCacheCluster_Engine_memcached
=== PAUSE TestAccElastiCacheCluster_Engine_memcached
=== RUN TestAccElastiCacheCluster_Engine_redis
=== PAUSE TestAccElastiCacheCluster_Engine_redis
=== RUN TestAccElastiCacheCluster_disappears
=== PAUSE TestAccElastiCacheCluster_disappears
=== RUN TestAccElastiCacheCluster_Engine_redis_v5
=== PAUSE TestAccElastiCacheCluster_Engine_redis_v5
=== RUN TestAccElastiCacheCluster_Engine_None
=== PAUSE TestAccElastiCacheCluster_Engine_None
=== RUN TestAccElastiCacheCluster_PortRedis_default
=== PAUSE TestAccElastiCacheCluster_PortRedis_default
=== RUN TestAccElastiCacheCluster_ParameterGroupName_default
=== PAUSE TestAccElastiCacheCluster_ParameterGroupName_default
=== RUN TestAccElastiCacheCluster_ipDiscovery
=== PAUSE TestAccElastiCacheCluster_ipDiscovery
=== RUN TestAccElastiCacheCluster_port
=== PAUSE TestAccElastiCacheCluster_port
=== RUN TestAccElastiCacheCluster_snapshotsWithUpdates
=== PAUSE TestAccElastiCacheCluster_snapshotsWithUpdates
=== RUN TestAccElastiCacheCluster_NumCacheNodes_decrease
=== PAUSE TestAccElastiCacheCluster_NumCacheNodes_decrease
=== RUN TestAccElastiCacheCluster_NumCacheNodes_increase
=== PAUSE TestAccElastiCacheCluster_NumCacheNodes_increase
=== RUN TestAccElastiCacheCluster_NumCacheNodes_increaseWithPreferredAvailabilityZones
=== PAUSE TestAccElastiCacheCluster_NumCacheNodes_increaseWithPreferredAvailabilityZones
=== RUN TestAccElastiCacheCluster_vpc
=== PAUSE TestAccElastiCacheCluster_vpc
=== RUN TestAccElastiCacheCluster_multiAZInVPC
=== PAUSE TestAccElastiCacheCluster_multiAZInVPC
=== RUN TestAccElastiCacheCluster_AZMode_memcached
=== PAUSE TestAccElastiCacheCluster_AZMode_memcached
=== RUN TestAccElastiCacheCluster_AZMode_redis
=== PAUSE TestAccElastiCacheCluster_AZMode_redis
=== RUN TestAccElastiCacheCluster_EngineVersion_memcached
=== PAUSE TestAccElastiCacheCluster_EngineVersion_memcached
=== RUN TestAccElastiCacheCluster_EngineVersion_redis
=== PAUSE TestAccElastiCacheCluster_EngineVersion_redis
=== RUN TestAccElastiCacheCluster_NodeTypeResize_memcached
=== PAUSE TestAccElastiCacheCluster_NodeTypeResize_memcached
=== RUN TestAccElastiCacheCluster_NodeTypeResize_redis
=== PAUSE TestAccElastiCacheCluster_NodeTypeResize_redis
=== RUN TestAccElastiCacheCluster_NumCacheNodes_redis
=== PAUSE TestAccElastiCacheCluster_NumCacheNodes_redis
=== RUN TestAccElastiCacheCluster_ReplicationGroupID_availabilityZone
=== PAUSE TestAccElastiCacheCluster_ReplicationGroupID_availabilityZone
=== RUN TestAccElastiCacheCluster_ReplicationGroupID_transitEncryption
=== PAUSE TestAccElastiCacheCluster_ReplicationGroupID_transitEncryption
=== RUN TestAccElastiCacheCluster_ReplicationGroupID_singleReplica
=== PAUSE TestAccElastiCacheCluster_ReplicationGroupID_singleReplica
=== RUN TestAccElastiCacheCluster_ReplicationGroupID_multipleReplica
=== PAUSE TestAccElastiCacheCluster_ReplicationGroupID_multipleReplica
=== RUN TestAccElastiCacheCluster_Memcached_finalSnapshot
=== PAUSE TestAccElastiCacheCluster_Memcached_finalSnapshot
=== RUN TestAccElastiCacheCluster_Redis_finalSnapshot
=== PAUSE TestAccElastiCacheCluster_Redis_finalSnapshot
=== RUN TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
=== PAUSE TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
=== RUN TestAccElastiCacheCluster_Engine_Redis_LogDeliveryConfigurations
=== PAUSE TestAccElastiCacheCluster_Engine_Redis_LogDeliveryConfigurations
=== RUN TestAccElastiCacheCluster_tags
=== PAUSE TestAccElastiCacheCluster_tags
=== RUN TestAccElastiCacheCluster_tagWithOtherModification
=== PAUSE TestAccElastiCacheCluster_tagWithOtherModification
=== RUN TestAccElastiCacheCluster_TransitEncryption
=== PAUSE TestAccElastiCacheCluster_TransitEncryption
=== RUN TestAccElastiCacheCluster_outpost_memcached
=== PAUSE TestAccElastiCacheCluster_outpost_memcached
=== RUN TestAccElastiCacheCluster_outpost_redis
=== PAUSE TestAccElastiCacheCluster_outpost_redis
=== RUN TestAccElastiCacheCluster_outpostID_memcached
=== PAUSE TestAccElastiCacheCluster_outpostID_memcached
=== RUN TestAccElastiCacheCluster_outpostID_redis
=== PAUSE TestAccElastiCacheCluster_outpostID_redis
=== CONT TestAccElastiCacheCluster_Engine_memcached
=== CONT TestAccElastiCacheCluster_NodeTypeResize_memcached
=== CONT TestAccElastiCacheCluster_NumCacheNodes_decrease
=== CONT TestAccElastiCacheCluster_EngineVersion_redis
--- PASS: TestAccElastiCacheCluster_Engine_memcached (638.10s)
=== CONT TestAccElastiCacheCluster_EngineVersion_memcached
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_decrease (1069.69s)
=== CONT TestAccElastiCacheCluster_AZMode_redis
--- PASS: TestAccElastiCacheCluster_NodeTypeResize_memcached (1309.15s)
=== CONT TestAccElastiCacheCluster_AZMode_memcached
--- PASS: TestAccElastiCacheCluster_AZMode_redis (709.73s)
=== CONT TestAccElastiCacheCluster_multiAZInVPC
--- PASS: TestAccElastiCacheCluster_AZMode_memcached (673.98s)
=== CONT TestAccElastiCacheCluster_vpc
--- PASS: TestAccElastiCacheCluster_EngineVersion_memcached (1423.67s)
=== CONT TestAccElastiCacheCluster_NumCacheNodes_increaseWithPreferredAvailabilityZones
--- PASS: TestAccElastiCacheCluster_multiAZInVPC (768.89s)
=== CONT TestAccElastiCacheCluster_NumCacheNodes_increase
--- PASS: TestAccElastiCacheCluster_vpc (724.10s)
=== CONT TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_increaseWithPreferredAvailabilityZones (1136.25s)
=== CONT TestAccElastiCacheCluster_outpostID_redis
cluster_test.go:1433: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpostID_redis (0.42s)
=== CONT TestAccElastiCacheCluster_outpostID_memcached
cluster_test.go:1400: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpostID_memcached (0.26s)
=== CONT TestAccElastiCacheCluster_outpost_redis
cluster_test.go:1360: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpost_redis (0.18s)
=== CONT TestAccElastiCacheCluster_outpost_memcached
cluster_test.go:1320: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpost_memcached (0.15s)
=== CONT TestAccElastiCacheCluster_TransitEncryption
--- PASS: TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade (532.89s)
=== CONT TestAccElastiCacheCluster_tagWithOtherModification
--- PASS: TestAccElastiCacheCluster_TransitEncryption (339.61s)
=== CONT TestAccElastiCacheCluster_tags
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_increase (997.07s)
=== CONT TestAccElastiCacheCluster_Engine_Redis_LogDeliveryConfigurations
--- PASS: TestAccElastiCacheCluster_tags (634.14s)
=== CONT TestAccElastiCacheCluster_Engine_redis_v5
--- PASS: TestAccElastiCacheCluster_EngineVersion_redis (4208.44s)
=== CONT TestAccElastiCacheCluster_Engine_None
--- PASS: TestAccElastiCacheCluster_Engine_None (0.79s)
=== CONT TestAccElastiCacheCluster_ReplicationGroupID_singleReplica
--- PASS: TestAccElastiCacheCluster_tagWithOtherModification (1456.44s)
=== CONT TestAccElastiCacheCluster_Redis_finalSnapshot
--- PASS: TestAccElastiCacheCluster_Engine_Redis_LogDeliveryConfigurations (1157.84s)
=== CONT TestAccElastiCacheCluster_Memcached_finalSnapshot
--- PASS: TestAccElastiCacheCluster_Memcached_finalSnapshot (1.31s)
=== CONT TestAccElastiCacheCluster_ReplicationGroupID_multipleReplica
--- PASS: TestAccElastiCacheCluster_Engine_redis_v5 (679.59s)
=== CONT TestAccElastiCacheCluster_ReplicationGroupID_availabilityZone
--- PASS: TestAccElastiCacheCluster_Redis_finalSnapshot (741.42s)
=== CONT TestAccElastiCacheCluster_ReplicationGroupID_transitEncryption
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_singleReplica (1357.48s)
=== CONT TestAccElastiCacheCluster_port
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_multipleReplica (1268.17s)
=== CONT TestAccElastiCacheCluster_snapshotsWithUpdates
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_availabilityZone (1127.14s)
=== CONT TestAccElastiCacheCluster_ipDiscovery
--- PASS: TestAccElastiCacheCluster_port (681.93s)
=== CONT TestAccElastiCacheCluster_disappears
--- PASS: TestAccElastiCacheCluster_ipDiscovery (722.59s)
=== CONT TestAccElastiCacheCluster_Engine_redis
--- PASS: TestAccElastiCacheCluster_snapshotsWithUpdates (770.93s)
=== CONT TestAccElastiCacheCluster_ParameterGroupName_default
--- PASS: TestAccElastiCacheCluster_disappears (708.12s)
=== CONT TestAccElastiCacheCluster_NumCacheNodes_redis
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_redis (1.16s)
=== CONT TestAccElastiCacheCluster_NodeTypeResize_redis
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_transitEncryption (1590.87s)
=== CONT TestAccElastiCacheCluster_PortRedis_default
--- PASS: TestAccElastiCacheCluster_Engine_redis (678.10s)
--- PASS: TestAccElastiCacheCluster_ParameterGroupName_default (636.67s)
--- PASS: TestAccElastiCacheCluster_PortRedis_default (595.60s)
--- PASS: TestAccElastiCacheCluster_NodeTypeResize_redis (1599.91s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 8563.631s% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccElastiCacheGlobalReplicationGroup_' PKG=elasticache ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elasticache/... -v -count 1 -parallel 4 -run=TestAccElastiCacheGlobalReplicationGroup_ -timeout 720m
2024/10/21 12:03:58 Initializing Terraform AWS Provider...
=== RUN TestAccElastiCacheGlobalReplicationGroup_Redis_basic
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_Redis_basic
=== RUN TestAccElastiCacheGlobalReplicationGroup_Valkey_basic
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_Valkey_basic
=== RUN TestAccElastiCacheGlobalReplicationGroup_disappears
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_disappears
=== RUN TestAccElastiCacheGlobalReplicationGroup_description
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_description
=== RUN TestAccElastiCacheGlobalReplicationGroup_nodeType_createNoChange
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_nodeType_createNoChange
=== RUN TestAccElastiCacheGlobalReplicationGroup_nodeType_createWithChange
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_nodeType_createWithChange
=== RUN TestAccElastiCacheGlobalReplicationGroup_nodeType_setNoChange
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_nodeType_setNoChange
=== RUN TestAccElastiCacheGlobalReplicationGroup_nodeType_update
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_nodeType_update
=== RUN TestAccElastiCacheGlobalReplicationGroup_automaticFailover_createNoChange
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_automaticFailover_createNoChange
=== RUN TestAccElastiCacheGlobalReplicationGroup_automaticFailover_createWithChange
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_automaticFailover_createWithChange
=== RUN TestAccElastiCacheGlobalReplicationGroup_automaticFailover_setNoChange
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_automaticFailover_setNoChange
=== RUN TestAccElastiCacheGlobalReplicationGroup_automaticFailover_update
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_automaticFailover_update
=== RUN TestAccElastiCacheGlobalReplicationGroup_multipleSecondaries
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_multipleSecondaries
=== RUN TestAccElastiCacheGlobalReplicationGroup_ReplaceSecondary_differentRegion
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_ReplaceSecondary_differentRegion
=== RUN TestAccElastiCacheGlobalReplicationGroup_clusterMode_basic
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_clusterMode_basic
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_NoChange
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_NoChange
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_Increase
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_Increase
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_Decrease
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_Decrease
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnUpdate_Increase
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnUpdate_Increase
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnUpdate_Decrease
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnUpdate_Decrease
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v6
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v6
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v6x
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v5
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v5
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Valkey_v7
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Valkey_v7
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion
=== RUN TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade
=== RUN TestAccElastiCacheGlobalReplicationGroup_UpdateParameterGroupName
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_UpdateParameterGroupName
=== CONT TestAccElastiCacheGlobalReplicationGroup_Redis_basic
=== CONT TestAccElastiCacheGlobalReplicationGroup_UpdateParameterGroupName
=== CONT TestAccElastiCacheGlobalReplicationGroup_ReplaceSecondary_differentRegion
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_Redis_basic (1057.79s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v6
--- PASS: TestAccElastiCacheGlobalReplicationGroup_UpdateParameterGroupName (1898.64s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade (1900.92s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v6 (860.06s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Valkey_v7
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade_6x (1074.75s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v5
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Valkey_v7 (1056.85s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_ReplaceSecondary_differentRegion (3337.10s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_Decrease
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorUpgrade (1888.54s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnUpdate_Decrease
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v6x (1064.47s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnUpdate_Increase
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_NoChange_Redis_v5 (1086.99s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade_6x (1046.52s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_Decrease (2730.26s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_MinorUpgrade (1053.20s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnUpdate_Decrease (2636.12s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnUpdate_Increase (2480.00s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnUpdate_NoVersion (1063.30s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_nodeType_update
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorDowngrade (1106.58s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_multipleSecondaries
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade_6x (2000.56s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_automaticFailover_update
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MajorUpgrade (2178.29s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_automaticFailover_setNoChange
--- PASS: TestAccElastiCacheGlobalReplicationGroup_nodeType_update (2053.31s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_automaticFailover_createWithChange
--- PASS: TestAccElastiCacheGlobalReplicationGroup_automaticFailover_update (1272.46s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_automaticFailover_createNoChange
--- PASS: TestAccElastiCacheGlobalReplicationGroup_automaticFailover_setNoChange (1180.50s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_nodeType_setNoChange
--- PASS: TestAccElastiCacheGlobalReplicationGroup_automaticFailover_createWithChange (1199.90s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_disappears
--- PASS: TestAccElastiCacheGlobalReplicationGroup_automaticFailover_createNoChange (1201.18s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_description
--- PASS: TestAccElastiCacheGlobalReplicationGroup_nodeType_setNoChange (1093.93s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_NoVersion (1.54s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_multipleSecondaries (3622.24s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_disappears (1085.40s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade
--- PASS: TestAccElastiCacheGlobalReplicationGroup_description (1088.63s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_nodeType_createWithChange
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetParameterGroupOnCreate_MinorUpgrade (903.04s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnUpdate_MinorUpgrade (1593.68s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_Valkey_basic
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MinorDowngrade (1010.99s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_NoChange
--- PASS: TestAccElastiCacheGlobalReplicationGroup_nodeType_createWithChange (1669.75s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_Increase
--- PASS: TestAccElastiCacheGlobalReplicationGroup_Valkey_basic (1109.25s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_clusterMode_basic
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_NoChange (1402.16s)
=== CONT TestAccElastiCacheGlobalReplicationGroup_nodeType_createNoChange
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetEngineVersionOnCreate_MajorUpgrade_6x (1993.57s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_clusterMode_basic (1319.49s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_nodeType_createNoChange (1126.08s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_SetNumNodeGroupsOnCreate_Increase (2386.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 15784.228s% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccElastiCacheParameterGroup_\|TestAccElastiCacheReplicationGroup_' PKG=elasticache ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elasticache/... -v -count 1 -parallel 4 -run=TestAccElastiCacheParameterGroup_\|TestAccElastiCacheReplicationGroup_ -timeout 720m
2024/10/21 17:44:19 Initializing Terraform AWS Provider...
=== RUN TestAccElastiCacheParameterGroup_Redis_basic
=== PAUSE TestAccElastiCacheParameterGroup_Redis_basic
=== RUN TestAccElastiCacheParameterGroup_Valkey_basic
=== PAUSE TestAccElastiCacheParameterGroup_Valkey_basic
=== RUN TestAccElastiCacheParameterGroup_disappears
=== PAUSE TestAccElastiCacheParameterGroup_disappears
=== RUN TestAccElastiCacheParameterGroup_addParameter
=== PAUSE TestAccElastiCacheParameterGroup_addParameter
=== RUN TestAccElastiCacheParameterGroup_removeAllParameters
=== PAUSE TestAccElastiCacheParameterGroup_removeAllParameters
=== RUN TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_allParameters
=== PAUSE TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_allParameters
=== RUN TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_remainingParameters
=== PAUSE TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_remainingParameters
=== RUN TestAccElastiCacheParameterGroup_switchReservedMemoryParameter
=== PAUSE TestAccElastiCacheParameterGroup_switchReservedMemoryParameter
=== RUN TestAccElastiCacheParameterGroup_updateReservedMemoryParameter
=== PAUSE TestAccElastiCacheParameterGroup_updateReservedMemoryParameter
=== RUN TestAccElastiCacheParameterGroup_uppercaseName
=== PAUSE TestAccElastiCacheParameterGroup_uppercaseName
=== RUN TestAccElastiCacheParameterGroup_description
=== PAUSE TestAccElastiCacheParameterGroup_description
=== RUN TestAccElastiCacheParameterGroup_tags
=== PAUSE TestAccElastiCacheParameterGroup_tags
=== RUN TestAccElastiCacheReplicationGroup_Redis_basic
=== PAUSE TestAccElastiCacheReplicationGroup_Redis_basic
=== RUN TestAccElastiCacheReplicationGroup_Redis_basic_v5
=== PAUSE TestAccElastiCacheReplicationGroup_Redis_basic_v5
=== RUN TestAccElastiCacheReplicationGroup_Valkey_basic
=== PAUSE TestAccElastiCacheReplicationGroup_Valkey_basic
=== RUN TestAccElastiCacheReplicationGroup_uppercase
=== PAUSE TestAccElastiCacheReplicationGroup_uppercase
=== RUN TestAccElastiCacheReplicationGroup_Redis_EngineVersion_v7
=== PAUSE TestAccElastiCacheReplicationGroup_Redis_EngineVersion_v7
=== RUN TestAccElastiCacheReplicationGroup_EngineVersion_update
=== PAUSE TestAccElastiCacheReplicationGroup_EngineVersion_update
=== RUN TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion
=== PAUSE TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion
=== RUN TestAccElastiCacheReplicationGroup_Engine_RedisToValkey
=== PAUSE TestAccElastiCacheReplicationGroup_Engine_RedisToValkey
=== RUN TestAccElastiCacheReplicationGroup_disappears
=== PAUSE TestAccElastiCacheReplicationGroup_disappears
=== RUN TestAccElastiCacheReplicationGroup_updateDescription
=== PAUSE TestAccElastiCacheReplicationGroup_updateDescription
=== RUN TestAccElastiCacheReplicationGroup_updateMaintenanceWindow
=== PAUSE TestAccElastiCacheReplicationGroup_updateMaintenanceWindow
=== RUN TestAccElastiCacheReplicationGroup_updateUserGroups
=== PAUSE TestAccElastiCacheReplicationGroup_updateUserGroups
=== RUN TestAccElastiCacheReplicationGroup_updateNodeSize
=== PAUSE TestAccElastiCacheReplicationGroup_updateNodeSize
=== RUN TestAccElastiCacheReplicationGroup_updateParameterGroup
=== PAUSE TestAccElastiCacheReplicationGroup_updateParameterGroup
=== RUN TestAccElastiCacheReplicationGroup_authToken
=== PAUSE TestAccElastiCacheReplicationGroup_authToken
=== RUN TestAccElastiCacheReplicationGroup_stateUpgrade5270
=== PAUSE TestAccElastiCacheReplicationGroup_stateUpgrade5270
=== RUN TestAccElastiCacheReplicationGroup_stateUpgrade5590
=== PAUSE TestAccElastiCacheReplicationGroup_stateUpgrade5590
=== RUN TestAccElastiCacheReplicationGroup_vpc
=== PAUSE TestAccElastiCacheReplicationGroup_vpc
=== RUN TestAccElastiCacheReplicationGroup_multiAzNotInVPC
=== PAUSE TestAccElastiCacheReplicationGroup_multiAzNotInVPC
=== RUN TestAccElastiCacheReplicationGroup_multiAzNotInVPC_repeated
=== PAUSE TestAccElastiCacheReplicationGroup_multiAzNotInVPC_repeated
=== RUN TestAccElastiCacheReplicationGroup_multiAzInVPC
=== PAUSE TestAccElastiCacheReplicationGroup_multiAzInVPC
=== RUN TestAccElastiCacheReplicationGroup_deprecatedAvailabilityZones_multiAzInVPC
=== PAUSE TestAccElastiCacheReplicationGroup_deprecatedAvailabilityZones_multiAzInVPC
=== RUN TestAccElastiCacheReplicationGroup_ValidationMultiAz_noAutomaticFailover
=== PAUSE TestAccElastiCacheReplicationGroup_ValidationMultiAz_noAutomaticFailover
=== RUN TestAccElastiCacheReplicationGroup_ipDiscovery
=== PAUSE TestAccElastiCacheReplicationGroup_ipDiscovery
=== RUN TestAccElastiCacheReplicationGroup_networkType
=== PAUSE TestAccElastiCacheReplicationGroup_networkType
=== RUN TestAccElastiCacheReplicationGroup_ClusterMode_basic
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterMode_basic
=== RUN TestAccElastiCacheReplicationGroup_ClusterMode_nonClusteredParameterGroup
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterMode_nonClusteredParameterGroup
=== RUN TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp
=== RUN TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown
=== RUN TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup
=== RUN TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp
=== RUN TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown
=== RUN TestAccElastiCacheReplicationGroup_ClusterMode_singleNode
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterMode_singleNode
=== RUN TestAccElastiCacheReplicationGroup_ClusterMode_updateFromDisabled_Compatible_Enabled
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterMode_updateFromDisabled_Compatible_Enabled
=== RUN TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup
=== PAUSE TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup
=== RUN TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError
=== PAUSE TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError
=== RUN TestAccElastiCacheReplicationGroup_enableSnapshotting
=== PAUSE TestAccElastiCacheReplicationGroup_enableSnapshotting
=== RUN TestAccElastiCacheReplicationGroup_transitEncryptionWithAuthToken
=== PAUSE TestAccElastiCacheReplicationGroup_transitEncryptionWithAuthToken
=== RUN TestAccElastiCacheReplicationGroup_transitEncryption5x
=== PAUSE TestAccElastiCacheReplicationGroup_transitEncryption5x
=== RUN TestAccElastiCacheReplicationGroup_transitEncryption7x
=== PAUSE TestAccElastiCacheReplicationGroup_transitEncryption7x
=== RUN TestAccElastiCacheReplicationGroup_enableAtRestEncryption
=== PAUSE TestAccElastiCacheReplicationGroup_enableAtRestEncryption
=== RUN TestAccElastiCacheReplicationGroup_useCMKKMSKeyID
=== PAUSE TestAccElastiCacheReplicationGroup_useCMKKMSKeyID
=== RUN TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic
=== PAUSE TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic
=== RUN TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverDisabled
=== PAUSE TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverDisabled
=== RUN TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverEnabled
=== PAUSE TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverEnabled
=== RUN TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters
=== PAUSE TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters
=== RUN TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled
=== PAUSE TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled
=== RUN TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange
=== PAUSE TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange
=== RUN TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster
=== PAUSE TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster
=== RUN TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_atTargetSize
=== PAUSE TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_atTargetSize
=== RUN TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown
=== PAUSE TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown
=== RUN TestAccElastiCacheReplicationGroup_tags
=== PAUSE TestAccElastiCacheReplicationGroup_tags
=== RUN TestAccElastiCacheReplicationGroup_tagWithOtherModification
=== PAUSE TestAccElastiCacheReplicationGroup_tagWithOtherModification
=== RUN TestAccElastiCacheReplicationGroup_finalSnapshot
=== PAUSE TestAccElastiCacheReplicationGroup_finalSnapshot
=== RUN TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade
=== PAUSE TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade
=== RUN TestAccElastiCacheReplicationGroup_Validation_noNodeType
=== PAUSE TestAccElastiCacheReplicationGroup_Validation_noNodeType
=== RUN TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType
=== PAUSE TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType
=== RUN TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic
=== PAUSE TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic
=== RUN TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full
=== PAUSE TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full
=== RUN TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears
=== PAUSE TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears
=== RUN TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic
=== PAUSE TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic
=== RUN TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary
=== PAUSE TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary
=== RUN TestAccElastiCacheReplicationGroup_dataTiering
=== PAUSE TestAccElastiCacheReplicationGroup_dataTiering
=== RUN TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Disabled
=== PAUSE TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Disabled
=== RUN TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Enabled
=== PAUSE TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Enabled
=== CONT TestAccElastiCacheParameterGroup_Redis_basic
=== CONT TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp
=== CONT TestAccElastiCacheReplicationGroup_disappears
=== CONT TestAccElastiCacheParameterGroup_description
--- PASS: TestAccElastiCacheParameterGroup_description (14.23s)
=== CONT TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled
--- PASS: TestAccElastiCacheParameterGroup_Redis_basic (14.25s)
=== CONT TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Enabled
--- PASS: TestAccElastiCacheReplicationGroup_disappears (769.48s)
=== CONT TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Disabled
--- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Enabled (1095.42s)
=== CONT TestAccElastiCacheReplicationGroup_dataTiering
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled (1540.55s)
=== CONT TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp (1627.46s)
=== CONT TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic
--- PASS: TestAccElastiCacheReplicationGroup_dataTiering (722.74s)
=== CONT TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears
--- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Disabled (1070.69s)
=== CONT TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary (1091.39s)
=== CONT TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears (2111.60s)
=== CONT TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full (2822.34s)
=== CONT TestAccElastiCacheReplicationGroup_Validation_noNodeType
--- PASS: TestAccElastiCacheReplicationGroup_Validation_noNodeType (4.95s)
=== CONT TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade
--- PASS: TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType (1111.23s)
=== CONT TestAccElastiCacheReplicationGroup_finalSnapshot
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic (2489.56s)
=== CONT TestAccElastiCacheReplicationGroup_tagWithOtherModification
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic (3509.55s)
=== CONT TestAccElastiCacheReplicationGroup_tags
--- PASS: TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade (835.97s)
=== CONT TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown
--- PASS: TestAccElastiCacheReplicationGroup_finalSnapshot (596.10s)
=== CONT TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_atTargetSize
--- PASS: TestAccElastiCacheReplicationGroup_tags (893.49s)
=== CONT TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_atTargetSize (1140.92s)
=== CONT TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown (1379.77s)
=== CONT TestAccElastiCacheReplicationGroup_transitEncryptionWithAuthToken
--- PASS: TestAccElastiCacheReplicationGroup_tagWithOtherModification (2017.21s)
=== CONT TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters
--- PASS: TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters (1.78s)
=== CONT TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverEnabled
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster (1457.03s)
=== CONT TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverDisabled
--- PASS: TestAccElastiCacheReplicationGroup_transitEncryptionWithAuthToken (743.48s)
=== CONT TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange (1405.78s)
=== CONT TestAccElastiCacheReplicationGroup_useCMKKMSKeyID
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverEnabled (1449.64s)
=== CONT TestAccElastiCacheReplicationGroup_enableAtRestEncryption
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverDisabled (1347.99s)
=== CONT TestAccElastiCacheReplicationGroup_uppercase
--- PASS: TestAccElastiCacheReplicationGroup_useCMKKMSKeyID (678.62s)
=== CONT TestAccElastiCacheReplicationGroup_transitEncryption7x
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic (1354.11s)
=== CONT TestAccElastiCacheReplicationGroup_Engine_RedisToValkey
--- PASS: TestAccElastiCacheReplicationGroup_enableAtRestEncryption (692.68s)
=== CONT TestAccElastiCacheReplicationGroup_transitEncryption5x
--- PASS: TestAccElastiCacheReplicationGroup_uppercase (711.04s)
=== CONT TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion (916.78s)
=== CONT TestAccElastiCacheReplicationGroup_EngineVersion_update
--- PASS: TestAccElastiCacheReplicationGroup_Engine_RedisToValkey (1620.31s)
=== CONT TestAccElastiCacheReplicationGroup_Redis_EngineVersion_v7
--- PASS: TestAccElastiCacheReplicationGroup_transitEncryption5x (1466.24s)
=== CONT TestAccElastiCacheReplicationGroup_multiAzNotInVPC
--- PASS: TestAccElastiCacheReplicationGroup_Redis_EngineVersion_v7 (685.12s)
=== CONT TestAccElastiCacheReplicationGroup_ValidationMultiAz_noAutomaticFailover
--- PASS: TestAccElastiCacheReplicationGroup_ValidationMultiAz_noAutomaticFailover (1.32s)
=== CONT TestAccElastiCacheReplicationGroup_deprecatedAvailabilityZones_multiAzInVPC
--- PASS: TestAccElastiCacheReplicationGroup_transitEncryption7x (2410.98s)
=== CONT TestAccElastiCacheReplicationGroup_multiAzInVPC
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC (852.79s)
=== CONT TestAccElastiCacheReplicationGroup_multiAzNotInVPC_repeated
--- PASS: TestAccElastiCacheReplicationGroup_deprecatedAvailabilityZones_multiAzInVPC (776.52s)
=== CONT TestAccElastiCacheReplicationGroup_Redis_basic_v5
--- PASS: TestAccElastiCacheReplicationGroup_multiAzInVPC (797.17s)
=== CONT TestAccElastiCacheReplicationGroup_Valkey_basic
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC_repeated (779.07s)
=== CONT TestAccElastiCacheReplicationGroup_ClusterMode_singleNode
--- PASS: TestAccElastiCacheReplicationGroup_Redis_basic_v5 (358.50s)
=== CONT TestAccElastiCacheReplicationGroup_enableSnapshotting
--- PASS: TestAccElastiCacheReplicationGroup_Valkey_basic (682.79s)
=== CONT TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError
--- PASS: TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError (0.82s)
=== CONT TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup
--- PASS: TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup (0.73s)
=== CONT TestAccElastiCacheReplicationGroup_ClusterMode_updateFromDisabled_Compatible_Enabled
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_singleNode (715.33s)
=== CONT TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_allParameters
--- PASS: TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_allParameters (22.69s)
=== CONT TestAccElastiCacheParameterGroup_uppercaseName
--- PASS: TestAccElastiCacheParameterGroup_uppercaseName (13.73s)
=== CONT TestAccElastiCacheParameterGroup_updateReservedMemoryParameter
--- PASS: TestAccElastiCacheParameterGroup_updateReservedMemoryParameter (22.07s)
=== CONT TestAccElastiCacheParameterGroup_switchReservedMemoryParameter
--- PASS: TestAccElastiCacheParameterGroup_switchReservedMemoryParameter (22.72s)
=== CONT TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_remainingParameters
--- PASS: TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_remainingParameters (22.67s)
=== CONT TestAccElastiCacheParameterGroup_addParameter
--- PASS: TestAccElastiCacheParameterGroup_addParameter (21.48s)
=== CONT TestAccElastiCacheParameterGroup_removeAllParameters
--- PASS: TestAccElastiCacheReplicationGroup_enableSnapshotting (826.02s)
=== CONT TestAccElastiCacheParameterGroup_disappears
--- PASS: TestAccElastiCacheParameterGroup_disappears (11.25s)
=== CONT TestAccElastiCacheParameterGroup_Valkey_basic
--- PASS: TestAccElastiCacheParameterGroup_removeAllParameters (26.37s)
=== CONT TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp
--- PASS: TestAccElastiCacheParameterGroup_Valkey_basic (13.38s)
=== CONT TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown (1816.33s)
=== CONT TestAccElastiCacheReplicationGroup_ClusterMode_basic
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_updateFromDisabled_Compatible_Enabled (2385.00s)
=== CONT TestAccElastiCacheReplicationGroup_ClusterMode_nonClusteredParameterGroup
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp (1895.85s)
=== CONT TestAccElastiCacheParameterGroup_tags
--- PASS: TestAccElastiCacheParameterGroup_tags (29.91s)
=== CONT TestAccElastiCacheReplicationGroup_updateParameterGroup
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_update (5409.03s)
=== CONT TestAccElastiCacheReplicationGroup_vpc
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_nonClusteredParameterGroup (746.08s)
=== CONT TestAccElastiCacheReplicationGroup_stateUpgrade5590
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (873.39s)
=== CONT TestAccElastiCacheReplicationGroup_stateUpgrade5270
--- PASS: TestAccElastiCacheReplicationGroup_updateParameterGroup (903.78s)
=== CONT TestAccElastiCacheReplicationGroup_authToken
--- PASS: TestAccElastiCacheReplicationGroup_vpc (672.85s)
=== CONT TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup
--- PASS: TestAccElastiCacheReplicationGroup_stateUpgrade5270 (583.42s)
=== CONT TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown
--- PASS: TestAccElastiCacheReplicationGroup_stateUpgrade5590 (646.42s)
=== CONT TestAccElastiCacheReplicationGroup_updateUserGroups
--- PASS: TestAccElastiCacheReplicationGroup_authToken (1276.76s)
=== CONT TestAccElastiCacheReplicationGroup_updateNodeSize
--- PASS: TestAccElastiCacheReplicationGroup_updateUserGroups (1056.02s)
=== CONT TestAccElastiCacheReplicationGroup_updateMaintenanceWindow
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup (1613.06s)
=== CONT TestAccElastiCacheReplicationGroup_ipDiscovery
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown (1771.40s)
=== CONT TestAccElastiCacheReplicationGroup_updateDescription
--- PASS: TestAccElastiCacheReplicationGroup_updateMaintenanceWindow (837.40s)
=== CONT TestAccElastiCacheReplicationGroup_Redis_basic
--- PASS: TestAccElastiCacheReplicationGroup_ipDiscovery (942.22s)
=== CONT TestAccElastiCacheReplicationGroup_networkType
--- PASS: TestAccElastiCacheReplicationGroup_updateDescription (825.79s)
--- PASS: TestAccElastiCacheReplicationGroup_Redis_basic (745.43s)
--- PASS: TestAccElastiCacheReplicationGroup_updateNodeSize (1839.87s)
--- PASS: TestAccElastiCacheReplicationGroup_networkType (1036.38s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 20141.989s% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccElastiCacheServerlessCache_' PKG=elasticache ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elasticache/... -v -count 1 -parallel 4 -run=TestAccElastiCacheServerlessCache_ -timeout 720m
2024/10/22 05:54:33 Initializing Terraform AWS Provider...
=== RUN TestAccElastiCacheServerlessCache_basicRedis
=== PAUSE TestAccElastiCacheServerlessCache_basicRedis
=== RUN TestAccElastiCacheServerlessCache_basicValkey
=== PAUSE TestAccElastiCacheServerlessCache_basicValkey
=== RUN TestAccElastiCacheServerlessCache_full
=== PAUSE TestAccElastiCacheServerlessCache_full
=== RUN TestAccElastiCacheServerlessCache_fullRedis
=== PAUSE TestAccElastiCacheServerlessCache_fullRedis
=== RUN TestAccElastiCacheServerlessCache_fullValkey
=== PAUSE TestAccElastiCacheServerlessCache_fullValkey
=== RUN TestAccElastiCacheServerlessCache_update
=== PAUSE TestAccElastiCacheServerlessCache_update
=== RUN TestAccElastiCacheServerlessCache_updatesc
=== PAUSE TestAccElastiCacheServerlessCache_updatesc
=== RUN TestAccElastiCacheServerlessCache_update_RedisToValkey
=== PAUSE TestAccElastiCacheServerlessCache_update_RedisToValkey
=== RUN TestAccElastiCacheServerlessCache_disappears
=== PAUSE TestAccElastiCacheServerlessCache_disappears
=== RUN TestAccElastiCacheServerlessCache_tags
=== PAUSE TestAccElastiCacheServerlessCache_tags
=== CONT TestAccElastiCacheServerlessCache_basicRedis
=== CONT TestAccElastiCacheServerlessCache_update
=== CONT TestAccElastiCacheServerlessCache_disappears
=== CONT TestAccElastiCacheServerlessCache_tags
--- PASS: TestAccElastiCacheServerlessCache_basicRedis (422.33s)
=== CONT TestAccElastiCacheServerlessCache_update_RedisToValkey
--- PASS: TestAccElastiCacheServerlessCache_tags (427.76s)
=== CONT TestAccElastiCacheServerlessCache_fullRedis
--- PASS: TestAccElastiCacheServerlessCache_disappears (482.00s)
=== CONT TestAccElastiCacheServerlessCache_fullValkey
--- PASS: TestAccElastiCacheServerlessCache_update (522.28s)
=== CONT TestAccElastiCacheServerlessCache_updatesc
--- PASS: TestAccElastiCacheServerlessCache_fullRedis (354.97s)
=== CONT TestAccElastiCacheServerlessCache_full
--- PASS: TestAccElastiCacheServerlessCache_fullValkey (302.94s)
=== CONT TestAccElastiCacheServerlessCache_basicValkey
--- PASS: TestAccElastiCacheServerlessCache_updatesc (324.84s)
--- PASS: TestAccElastiCacheServerlessCache_full (219.11s)
--- PASS: TestAccElastiCacheServerlessCache_basicValkey (219.32s)
--- PASS: TestAccElastiCacheServerlessCache_update_RedisToValkey (582.91s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 1010.262s
|
@relu Thanks for the contribution 🎉 👏. |
github-actions
bot
removed
the
prioritized
|
This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
Does this support direct in-place upgrades from Redis engine? |
This PR #39950 probably will make it able to do in-place upgrades. |
I was able to an in-place upgrade without the PR with the provider version 5.73.0. I did have to of course give the engine for provider but - worked really well. Awesome work! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for the newly introduced Valkey engine in AWS ElastiCache.
Relations
Closes #39641.
Closes #39711.
References
Output from Acceptance Testing
WIP