Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_iam_group_policy_attachments_exclusive: new resource #39732

Merged
merged 1 commit into from
Oct 16, 2024
Merged

r/aws_iam_group_policy_attachments_exclusive: new resource #39732

merged 1 commit into from
Oct 16, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Oct 15, 2024

Description

This resource will allow practitioners to retain exclusive ownership of customer managed policy attachments to IAM groups via Terraform.

Relations

Relates #39376
Closes #39381

Output from Acceptance Testing

% make testacc PKG=iam TESTS=TestAccIAMGroupPolicyAttachmentsExclusive_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMGroupPolicyAttachmentsExclusive_'  -timeout 360m
2024/10/15 15:41:33 Initializing Terraform AWS Provider...

--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_empty (14.72s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Policy (15.88s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Group (15.92s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_basic (16.48s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandRemoval (23.58s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandAddition (24.17s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_multiple (24.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        30.887s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 15, 2024
@jar-b
r/aws_iam_group_policy_attachments_exclusive: new resource
ec9afbd 
This resource will allow practitioners to retain exclusive ownership of customer managed policy attachments to IAM groups via Terraform.

```console
% make testacc PKG=iam TESTS=TestAccIAMGroupPolicyAttachmentsExclusive_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMGroupPolicyAttachmentsExclusive_'  -timeout 360m
2024/10/15 15:41:33 Initializing Terraform AWS Provider...

--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_empty (14.72s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Policy (15.88s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Group (15.92s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_basic (16.48s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandRemoval (23.58s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandAddition (24.17s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_multiple (24.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        30.887s
```
@jar-b jar-b force-pushed the f-group_attachment_exclusive branch from f75e05e to ec9afbd Compare October 15, 2024 20:00
@jar-b jar-b added the new-resource Introduces a new resource. label Oct 15, 2024
@jar-b jar-b marked this pull request as ready for review October 15, 2024 20:41
@jar-b jar-b requested a review from a team as a code owner October 15, 2024 20:41
ewbankkit
ewbankkit approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIAMGroupPolicyAttachmentsExclusive_' PKG=iam ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/iam/... -v -count 1 -parallel 3  -run=TestAccIAMGroupPolicyAttachmentsExclusive_ -timeout 360m
2024/10/16 08:09:43 Initializing Terraform AWS Provider...
=== RUN   TestAccIAMGroupPolicyAttachmentsExclusive_basic
=== PAUSE TestAccIAMGroupPolicyAttachmentsExclusive_basic
=== RUN   TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Group
=== PAUSE TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Group
=== RUN   TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Policy
=== PAUSE TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Policy
=== RUN   TestAccIAMGroupPolicyAttachmentsExclusive_multiple
=== PAUSE TestAccIAMGroupPolicyAttachmentsExclusive_multiple
=== RUN   TestAccIAMGroupPolicyAttachmentsExclusive_empty
=== PAUSE TestAccIAMGroupPolicyAttachmentsExclusive_empty
=== RUN   TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandRemoval
=== PAUSE TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandRemoval
=== RUN   TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandAddition
=== PAUSE TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandAddition
=== CONT  TestAccIAMGroupPolicyAttachmentsExclusive_basic
=== CONT  TestAccIAMGroupPolicyAttachmentsExclusive_empty
=== CONT  TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandAddition
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_empty (10.72s)
=== CONT  TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandRemoval
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_basic (12.37s)
=== CONT  TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Policy
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandAddition (17.75s)
=== CONT  TestAccIAMGroupPolicyAttachmentsExclusive_multiple
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Policy (9.89s)
=== CONT  TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Group
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_outOfBandRemoval (17.79s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_disappears_Group (10.08s)
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_multiple (18.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	42.015s

bateller
bateller approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@bateller bateller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jar-b jar-b merged commit 14689f2 into main Oct 16, 2024
56 checks passed
@jar-b jar-b deleted the f-group_attachment_exclusive branch October 16, 2024 17:04
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 16, 2024
@johnsonaj johnsonaj modified the milestones: v5.73.0, v5.72.1 Oct 16, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 16, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.72.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jar-b jar-b mentioned this pull request Oct 22, 2024
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bateller bateller bateller approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.72.1
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_iam_group_policy_attachments_exclusive
4 participants
@jar-b @ewbankkit @bateller @johnsonaj