Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_bedrock_inference_profiles: new data source #39342

Conversation

takakuni-classmethod
Copy link
Contributor

New datasources for Bedrock service:

  • aws_bedrock_inference_profiles
  • aws_bedrock_inference_profile

Description

Relations

Closes #39074

References

https://docs.aws.amazon.com/bedrock/latest/APIReference/API_ListInferenceProfiles.html
https://docs.aws.amazon.com/bedrock/latest/APIReference/API_GetInferenceProfile.html

Output from Acceptance Testing

% make testacc TESTS=TestAccBedrockInferenceProfilesDataSource_basic PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockInferenceProfilesDataSource_basic'  -timeout 360m
=== RUN   TestAccBedrockInferenceProfilesDataSource_basic
=== PAUSE TestAccBedrockInferenceProfilesDataSource_basic
=== CONT  TestAccBedrockInferenceProfilesDataSource_basic
--- PASS: TestAccBedrockInferenceProfilesDataSource_basic (13.36s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrock    17.479s
% make testacc TESTS=TestAccBedrockInferenceProfileDataSource_basic PKG=bedrock 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockInferenceProfileDataSource_basic'  -timeout 360m
=== RUN   TestAccBedrockInferenceProfileDataSource_basic
=== PAUSE TestAccBedrockInferenceProfileDataSource_basic
=== CONT  TestAccBedrockInferenceProfileDataSource_basic
--- PASS: TestAccBedrockInferenceProfileDataSource_basic (14.05s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrock    18.196s

@takakuni-classmethod takakuni-classmethod requested a review from a team as a code owner September 16, 2024 10:18
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/bedrock Issues and PRs that pertain to the bedrock service. needs-triage Waiting for first response or review from a maintainer. labels Sep 16, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @takakuni-classmethod 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@takakuni-classmethod takakuni-classmethod changed the title F aws bedrock inference profile datasource d/aws_bedrock_inference_profiles: new data source Sep 16, 2024
@takakuni-classmethod
Copy link
Contributor Author

Output from Acceptance Testing

% make testacc TESTS=TestAccBedrockInferenceProfileDataSource_basic PKG=bedrock 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockInferenceProfileDataSource_basic'  -timeout 360m
=== RUN   TestAccBedrockInferenceProfileDataSource_basic
=== PAUSE TestAccBedrockInferenceProfileDataSource_basic
=== CONT  TestAccBedrockInferenceProfileDataSource_basic
--- PASS: TestAccBedrockInferenceProfileDataSource_basic (13.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrock    18.054s
% make testacc TESTS=TestAccBedrockInferenceProfilesDataSource_basic PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockInferenceProfilesDataSource_basic'  -timeout 360m
=== RUN   TestAccBedrockInferenceProfilesDataSource_basic
=== PAUSE TestAccBedrockInferenceProfilesDataSource_basic
=== CONT  TestAccBedrockInferenceProfilesDataSource_basic
--- PASS: TestAccBedrockInferenceProfilesDataSource_basic (13.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrock    17.090s

@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 9, 2024
@ewbankkit ewbankkit self-assigned this Oct 9, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 9, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBedrock_serial/^CustomModel$$/^dataSourceBasic$$' PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/bedrock/... -v -count 1 -parallel 20  -run=TestAccBedrock_serial/^CustomModel$/^dataSourceBasic$ -timeout 360m
=== RUN   TestAccBedrock_serial
=== PAUSE TestAccBedrock_serial
=== CONT  TestAccBedrock_serial
=== RUN   TestAccBedrock_serial/CustomModel
=== RUN   TestAccBedrock_serial/CustomModel/dataSourceBasic
--- PASS: TestAccBedrock_serial (7140.14s)
    --- PASS: TestAccBedrock_serial/CustomModel (7140.14s)
        --- PASS: TestAccBedrock_serial/CustomModel/dataSourceBasic (7140.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrock	7145.247s
% make testacc TESTARGS='-run=TestAccBedrock_serial/^CustomModel$$/^pluralDataSourceBasic$$' PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/bedrock/... -v -count 1 -parallel 20  -run=TestAccBedrock_serial/^CustomModel$/^pluralDataSourceBasic$ -timeout 360m
=== RUN   TestAccBedrock_serial
=== PAUSE TestAccBedrock_serial
=== CONT  TestAccBedrock_serial
=== RUN   TestAccBedrock_serial/CustomModel
=== RUN   TestAccBedrock_serial/CustomModel/pluralDataSourceBasic
--- PASS: TestAccBedrock_serial (6298.94s)
    --- PASS: TestAccBedrock_serial/CustomModel (6298.94s)
        --- PASS: TestAccBedrock_serial/CustomModel/pluralDataSourceBasic (6298.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrock	6304.082s
% make testacc TESTARGS='-run=TestAccBedrockInferenceProfileDataSource_\|TestAccBedrockInferenceProfilesDataSource_basic' PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/bedrock/... -v -count 1 -parallel 20  -run=TestAccBedrockInferenceProfileDataSource_\|TestAccBedrockInferenceProfilesDataSource_basic -timeout 360m
=== RUN   TestAccBedrockInferenceProfileDataSource_basic
=== PAUSE TestAccBedrockInferenceProfileDataSource_basic
=== RUN   TestAccBedrockInferenceProfilesDataSource_basic
=== PAUSE TestAccBedrockInferenceProfilesDataSource_basic
=== CONT  TestAccBedrockInferenceProfileDataSource_basic
=== CONT  TestAccBedrockInferenceProfilesDataSource_basic
--- PASS: TestAccBedrockInferenceProfilesDataSource_basic (8.38s)
--- PASS: TestAccBedrockInferenceProfileDataSource_basic (8.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrock	13.976s
% make testacc TESTARGS='-run=TestAccBedrockFoundationModelDataSource_\|TestAccBedrockFoundationModelsDataSource_' PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/bedrock/... -v -count 1 -parallel 20  -run=TestAccBedrockFoundationModelDataSource_\|TestAccBedrockFoundationModelsDataSource_ -timeout 360m
=== RUN   TestAccBedrockFoundationModelDataSource_basic
=== PAUSE TestAccBedrockFoundationModelDataSource_basic
=== RUN   TestAccBedrockFoundationModelsDataSource_basic
=== PAUSE TestAccBedrockFoundationModelsDataSource_basic
=== RUN   TestAccBedrockFoundationModelsDataSource_byCustomizationType
=== PAUSE TestAccBedrockFoundationModelsDataSource_byCustomizationType
=== RUN   TestAccBedrockFoundationModelsDataSource_byInferenceType
=== PAUSE TestAccBedrockFoundationModelsDataSource_byInferenceType
=== RUN   TestAccBedrockFoundationModelsDataSource_byOutputModality
=== PAUSE TestAccBedrockFoundationModelsDataSource_byOutputModality
=== RUN   TestAccBedrockFoundationModelsDataSource_byProvider
=== PAUSE TestAccBedrockFoundationModelsDataSource_byProvider
=== CONT  TestAccBedrockFoundationModelDataSource_basic
=== CONT  TestAccBedrockFoundationModelsDataSource_byInferenceType
=== CONT  TestAccBedrockFoundationModelsDataSource_byOutputModality
=== CONT  TestAccBedrockFoundationModelsDataSource_byProvider
=== CONT  TestAccBedrockFoundationModelsDataSource_byCustomizationType
=== CONT  TestAccBedrockFoundationModelsDataSource_basic
--- PASS: TestAccBedrockFoundationModelsDataSource_byCustomizationType (9.30s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byProvider (9.31s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byInferenceType (9.64s)
--- PASS: TestAccBedrockFoundationModelsDataSource_basic (9.69s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byOutputModality (9.69s)
--- PASS: TestAccBedrockFoundationModelDataSource_basic (9.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrock	15.004s

…ategory: 'Bedrock') doesn't match file name prefix, expecting Bedrock".
@ewbankkit
Copy link
Contributor

@takakuni-classmethod Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7f260d9 into hashicorp:main Oct 10, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.71.0 milestone Oct 10, 2024
@takakuni-classmethod takakuni-classmethod deleted the f-aws_bedrock_inference_profile-datasource branch October 10, 2024 22:23
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/bedrock Issues and PRs that pertain to the bedrock service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bedrock cross-region inference
2 participants