-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_lexv2models_slot_type: fix audio_recognition_strategy
argument name
#39254
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…t name Previously this nested argument was misnamed `audio_recognition_settings`. If the correct name was provided, Terraform would fail indicating the argument name did not exist. ``` │ Error: Unsupported argument │ │ on main.tf line 71, in resource "aws_lexv2models_slot_type" "test": │ 71: audio_recognition_strategy = "UseSlotValuesAsCustomVocabulary" │ │ An argument named "audio_recognition_strategy" is not expected here. ``` If the incorrect name was provided, creation would fail as AutoFlex would be unable to write the result from the AWS data structure back to the Terraform data structure due to the mismatch in field names. ``` aws_lexv2models_slot_type.test: Creating... ╷ │ Error: Provider produced inconsistent result after apply │ │ When applying changes to aws_lexv2models_slot_type.test, provider "provider[\"registry.terraform.io/hashicorp/aws\"]" produced an unexpected new value: │ .value_selection_setting[0].advanced_recognition_setting[0].audio_recognition_setting: was cty.StringVal("UseSlotValuesAsCustomVocabulary"), but now null. │ │ This is a bug in the provider, which should be reported in the provider's own issue tracker. ``` As such, this technically breaking change to the schema definition is deemed acceptable within a minor release. ```console % make testacc PKG=lexv2models TESTS=TestAccLexV2ModelsSlotType_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.0 test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsSlotType_' -timeout 360m --- PASS: TestAccLexV2ModelsSlotType_values (42.82s) --- PASS: TestAccLexV2ModelsSlotType_valueSelectionSetting (44.74s) --- PASS: TestAccLexV2ModelsSlotType_disappears (45.08s) --- PASS: TestAccLexV2ModelsSlotType_basic (50.91s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models 56.975s ```
fcca45d
to
76ffa8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Previously this nested argument was misnamed
audio_recognition_settings
. If the correct name was provided, Terraform would fail indicating the argument name did not exist.If the incorrect name was provided, creation would fail as AutoFlex would be unable to write the result from the AWS data structure back to the Terraform data structure due to the mismatch in field names.
As such, this technically breaking change to the schema definition is deemed acceptable within a minor release.
Also fixes various issues with the registry documentation for
aws_lexv2models_slot_type
and adds a new example.Relations
Closes #39246
Closes #39247 (documentation changes incorporated into this PR)
References
Output from Acceptance Testing