-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_verifiedaccess_endpoint: fix crash when updating load_balancer_options.subnet_ids
#39196
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…_options.subnet_ids` ```console % make testacc PKG=ec2 TESTS=TestAccVerifiedAccess_serial/Endpoint/basic make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.0 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVerifiedAccess_serial/Endpoint/basic' -timeout 360m --- PASS: TestAccVerifiedAccess_serial (0.59s) --- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (1115.35s) --- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (1278.48s) --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1289.64s) --- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (1371.40s) --- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (1451.52s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1458.259s ```
32a32ad
to
c99227a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Can we add an acceptance test case for this?
Test results after updating acceptance tests: % make testacc PKG=ec2 TESTS=TestAccVerifiedAccess_serial/Endpoint ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVerifiedAccess_serial/Endpoint' -timeout 360m
--- PASS: TestAccVerifiedAccess_serial (0.52s)
--- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (1380.55s)
--- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (1390.69s)
--- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (1584.75s)
--- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (1099.79s)
--- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1227.56s)
--- PASS: TestAccVerifiedAccess_serial/Endpoint_subnetIDs (1632.08s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 3019.479s |
This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Fixes an incorrect assertion of a set type to an
[]interface{}
.Relations
Closes #39186
Output from Acceptance Testing