-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add data.aws_sns_topic tags attribute #38959
feature: Add data.aws_sns_topic tags attribute #38959
Conversation
add aws_sns_topic tags change to correct name remove additional spacing
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSNSTopicDataSource_' PKG=sns ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/sns/... -v -count 1 -parallel 2 -run=TestAccSNSTopicDataSource_ -timeout 360m
=== RUN TestAccSNSTopicDataSource_tags
=== PAUSE TestAccSNSTopicDataSource_tags
=== RUN TestAccSNSTopicDataSource_basic
=== PAUSE TestAccSNSTopicDataSource_basic
=== CONT TestAccSNSTopicDataSource_tags
=== CONT TestAccSNSTopicDataSource_basic
--- PASS: TestAccSNSTopicDataSource_tags (10.51s)
--- PASS: TestAccSNSTopicDataSource_basic (10.85s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 15.905s
@jmonte-sph Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add
data.aws_sns_topic
tags
attributeRelations
Closes #38910
Output from Acceptance Testing