Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add data.aws_sns_topic tags attribute #38959

Merged

Conversation

jmonte-sph
Copy link
Contributor

Description

Add data.aws_sns_topic tags attribute

Relations

Closes #38910

Output from Acceptance Testing

% make testacc TESTS=TestAccSNSTopicDataSource_tags PKG=sns
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopicDataSource_tags'  -timeout 360m
=== RUN   TestAccSNSTopicDataSource_tags
=== PAUSE TestAccSNSTopicDataSource_tags
=== CONT  TestAccSNSTopicDataSource_tags
--- PASS: TestAccSNSTopicDataSource_tags (22.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	35.306s
...
% make testacc TESTS=TestAccSNSTopicDataSource_basic PKG=sns
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopicDataSource_basic'  -timeout 360m
=== RUN   TestAccSNSTopicDataSource_basic
=== PAUSE TestAccSNSTopicDataSource_basic
=== CONT  TestAccSNSTopicDataSource_basic
--- PASS: TestAccSNSTopicDataSource_basic (24.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	42.769s
...

add aws_sns_topic tags

change to correct name

remove additional spacing
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sns Issues and PRs that pertain to the sns service. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. labels Aug 21, 2024
@jmonte-sph jmonte-sph marked this pull request as ready for review August 21, 2024 08:43
@jmonte-sph jmonte-sph requested a review from a team as a code owner August 21, 2024 08:43
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Aug 21, 2024
@ewbankkit ewbankkit self-assigned this Sep 3, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 3, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSNSTopicDataSource_' PKG=sns ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/sns/... -v -count 1 -parallel 2  -run=TestAccSNSTopicDataSource_ -timeout 360m
=== RUN   TestAccSNSTopicDataSource_tags
=== PAUSE TestAccSNSTopicDataSource_tags
=== RUN   TestAccSNSTopicDataSource_basic
=== PAUSE TestAccSNSTopicDataSource_basic
=== CONT  TestAccSNSTopicDataSource_tags
=== CONT  TestAccSNSTopicDataSource_basic
--- PASS: TestAccSNSTopicDataSource_tags (10.51s)
--- PASS: TestAccSNSTopicDataSource_basic (10.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	15.905s

@ewbankkit
Copy link
Contributor

@jmonte-sph Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 874527d into hashicorp:main Sep 3, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.66.0 milestone Sep 3, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Oct 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/sns Issues and PRs that pertain to the sns service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: data.aws_sns_topic should have a tags attribute
3 participants