Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appflow): add support for pagination and parallelism properties for aws_appflow_flow #38932

Merged
merged 11 commits into from
Oct 15, 2024

Conversation

mahadzaryab1
Copy link
Contributor

@mahadzaryab1 mahadzaryab1 commented Aug 20, 2024

Description

Relations

Closes #38714

References

Output from Acceptance Testing

I get the following error when trying to run unit/acceptance tests: cannot run Terraform provider tests: failed to find or install Terraform CLI from [0x1400359a240 0x140035702d0]: context deadline exceeded. Does anyone know how I can get around this?

% make testacc PKG=appflow TestAccAppFlowFlow_

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/appflow Issues and PRs that pertain to the appflow service. needs-triage Waiting for first response or review from a maintainer. labels Aug 20, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mahadzaryab1 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review August 20, 2024 01:38
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner August 20, 2024 01:38
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 20, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccAppFlowFlow_" PKG=appflow

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowFlow_ -timeout 360m
2024/10/15 11:48:10 Initializing Terraform AWS Provider...
--- PASS: TestAccAppFlowFlow_taskProperties (40.70s)
--- PASS: TestAccAppFlowFlow_disappears (43.57s)
--- PASS: TestAccAppFlowFlow_basic (50.06s)
--- PASS: TestAccAppFlowFlow_metadataCatalog (57.23s)
--- PASS: TestAccAppFlowFlow_task_mapAll (57.76s)
--- PASS: TestAccAppFlowFlow_tags_DefaultTags_nullOverlappingResourceTag (59.65s)
--- PASS: TestAccAppFlowFlow_update (72.49s)
--- PASS: TestAccAppFlowFlow_taskUpdate (72.53s)
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (73.47s)
--- PASS: TestAccAppFlowFlow_tags_EmptyMap (75.04s)
--- PASS: TestAccAppFlowFlow_tags_EmptyTag_OnUpdate_Replace (90.32s)
--- PASS: TestAccAppFlowFlow_tags_ComputedTag_OnUpdate_Replace (94.32s)
--- PASS: TestAccAppFlowFlow_tags_AddOnUpdate (94.37s)
--- PASS: TestAccAppFlowFlow_tags_DefaultTags_updateToProviderOnly (96.16s)
--- PASS: TestAccAppFlowFlow_tags_DefaultTags_updateToResourceOnly (96.51s)
--- PASS: TestAccAppFlowFlow_tags_EmptyTag_OnCreate (97.44s)
--- PASS: TestAccAppFlowFlow_tags_ComputedTag_OnCreate (49.24s)
--- PASS: TestAccAppFlowFlow_tags_null (60.60s)
--- PASS: TestAccAppFlowFlow_tags_DefaultTags_nullNonOverlappingResourceTag (46.34s)
--- PASS: TestAccAppFlowFlow_tags_DefaultTags_emptyResourceTag (48.23s)
--- PASS: TestAccAppFlowFlow_tags_DefaultTags_emptyProviderOnlyTag (38.05s)
--- PASS: TestAccAppFlowFlow_tags_EmptyTag_OnUpdate_Add (116.72s)
--- PASS: TestAccAppFlowFlow_tags_ComputedTag_OnUpdate_Add (63.58s)
--- PASS: TestAccAppFlowFlow_tags_DefaultTags_overlapping (123.30s)
--- PASS: TestAccAppFlowFlow_tags (134.75s)
--- PASS: TestAccAppFlowFlow_tags_DefaultTags_nonOverlapping (96.46s)
--- PASS: TestAccAppFlowFlow_tags_DefaultTags_providerOnly (141.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	148.433s

@johnsonaj
Copy link
Contributor

@mahadzaryab1 thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit e604986 into hashicorp:main Oct 15, 2024
37 checks passed
@github-actions github-actions bot added this to the v5.72.0 milestone Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appflow Issues and PRs that pertain to the appflow service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support for Pagination and Parallelism properties for appflow_flow
3 participants